RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.39k stars 10.51k forks source link

UI inconsistencies #18636

Closed reetp closed 10 months ago

reetp commented 4 years ago

Description:

'improvements' have been made to mentions to make them clickable. The colours are a horrendous p*ke yellow as mentioned elsewhere ( https://github.com/RocketChat/Rocket.Chat/issues/18135 ) and as this is based on the alert colour it is not easy to JUST change the mention colour without affecting everything else.

Oddly enough if you @ yourself it is in red. See screenshot.

Just to add to the bad UI you can click on a username/real Name, but they are just plain text colour and the only way you know they are clickable is if you hover over them and a hand appears.

This is contrary to other clickable links in Rocket eg URLs. They should be coloured or underlined etc.

Steps to reproduce:

Looks at any Mention. Colour is awful and not easy to change.

Hover over any Real Name/username and see the hand. It also highlights the whole line, not just the link.

Expected behavior:

Mention colours should be easy to change and not the same colour as the Alert colour.

Real Name/username links should be highlighted with a contrast colour and hover colour the same as any other type of link, and it should be selectable as per the mention colours above.

Actual behavior:

Server Setup Information:

Client Setup Information

Additional context

None

Relevant logs:

None applicable.

Images

No Hover - should be underlined or a contrasting colour to indicate clickable

Highlight1

Hover - should change colour and ONLY highlight name/username

Highlight2

Mention colours :-(

Highlight3

engelgabriel commented 4 years ago

We will add the same fade on hoover for username and real names as we have on other links. We don't want a different color for usernames as it will make it messier. Also, the different colors for mentions have a logic, that's why they are different for each type of mention.

@ yourself is red to make it easy to find your mentions, as they are the important mentions for you.