search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.4k stars 10.51k forks source link

Real names are not shown inside threads #18769

Closed Gummikavalier closed 3 years ago

Gummikavalier commented 4 years ago

Description:

I'm recreating this issue because the existing one did not get resolved in the threads rewrite, yet it was marked resolved.

In short: New installations of Rocket.Chat, tar or docker based, ignore Use Real Names server setting under threads. Instead usernames are shown.

Original issue: https://github.com/RocketChat/Rocket.Chat/issues/17519

Steps to reproduce:

  1. Activate Administration -> Layout -> User Interface -> Use Real Name
  2. User writes a reply in thread. The real name is shown correctly in the message.
  3. Close the thread view and open it again.

Expected behavior:

Names inside the thread should be real names.

Actual behavior:

Names inside the thread are usernames.

Server Setup Information:

Client Setup Information

Additional context

When looking at the database u.name is not written into the message. Supposedly it was removed on purpose in https://github.com/RocketChat/Rocket.Chat/pull/16343 . This issue has existed since this pull, yet it is not visible on (very) old instances that still write u.name into the messages for an unknown reason.

ipikiiskinen commented 4 years ago

We have this same issue with version 3.5.0, MongoDB 4.0.19. Installation uses rocket.chat from docker container (rocket.chat:3.5.0). We get the user data from AD (LDAP). This issue is in thread messages, quotes and email notifications.

jdsatava127 commented 4 years ago

We are having the same issue as well. Real name is not showing properly in threads and emails. We are using Docker image 3.5.4 with users from LDAP.

beranPro commented 4 years ago

same here

immaro commented 3 years ago

Same here, the problem still persists in v 3.7.1

bseclier commented 3 years ago

Same here, a fix would be great ! Thanks.

mbdwa commented 3 years ago

Which version will feature this fix? It is really annoying to check every ID for the real name manually.

Gummikavalier commented 3 years ago

This issue seems to have been resolved in RC 3.11.0. I checked that it is not using the solution provided by magicbelette, but the original issue of failing to resolve the username as name on the fly.

Gummikavalier commented 3 years ago

Correction: according to the database the name is written into DB but by some other part of the code.

Gummikavalier commented 3 years ago

The similar issue with reactions remains though: https://github.com/RocketChat/Rocket.Chat/issues/20501

Anyway, I'm closing this one.