RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.27k stars 10.44k forks source link

Node crash exporting messages with unset SMTP server #18911

Open enzote84 opened 4 years ago

enzote84 commented 4 years ago

Description:

Node app crash when I try to export messages from a channel and the SMTP outgoing server is not configured.

Steps to reproduce:

  1. Go to any channel
  2. Clic on Export Messages
  3. Select method: Export as file
  4. Clic on Export button

Expected behavior:

A file download process should start.

Actual behavior:

Node app crash.

Server Setup Information:

Client Setup Information

Workarround:

After configure the SMTP outgoing server the problem is resolved. Although, the file is sent by email instead of being downloaded.

Relevant logs:

No logs are produced when this happens.

ankar84 commented 4 years ago

Header a little bit confusing. I think something like Node crash exporting messages with unset SMTP server would much correct. I did try export messages to file and it works good - I get email with link to message archive.

enzote84 commented 4 years ago

Header a little bit confusing. I think something like Node crash exporting messages with unset SMTP server would much correct. I did try export messages to file and it works good - I get email with link to message archive.

I've changed the header as you recommended. Exporting to a file is also confusing. I would expect that functionality to start a file download from the browser or the desktop client, in which case it shouldn't be necessary to set SMTP server. Thanks for your reply. Regards