search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.67k stars 10.66k forks source link

Thread message notification does not disappear #19077

Open shaiton opened 4 years ago

shaiton commented 4 years ago

Description:

Once a thread message is appearing, I need to click on it in order to remove the blue notification picture. There is no other way to hide this notification.. In previous releases pressing ESC key removed all notifications from the current channel. Now, at least under Rocketchat release 3.6.1 there is no other way to clean this notification.

Please note that I am using the following feature : "Show thread messages in the main thread". Therefore, I am always able to see this "hidden" messages.

Steps to reproduce:

  1. ask someone to reply to a message in a "thread"
  2. try to remove this annoying notification either by opening this channel or by pressing ESC in this channel

Expected behavior:

as soon as I get to read this message, the notification should desapear. Alright, hard to define. Let's make it simple: hitting the ESC key should clear all current channel notifications

Actual behavior:

This blue notificatiion asside the channel name stay. It only disappear when I click on the actual "new" message

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

Bengrunt commented 4 years ago

Hello.

This behavior persists for v3.7.0. We're also affected by this issue.

The "mark channel as read" function should be able to clear new messages in channel threads as well and as expected.

ceefour commented 4 years ago

Still happens in 3.7.0, again sometimes

dfaure-kdab commented 4 years ago

I have "unread threads" which I cannot mark as read, no matter what I try, using rocketchat-desktop (currently 3.0.4, but it was the same with 2.x). The thread icon show "1" in blue. Filtering for Unread shows one thread. No blue circle on that thread. Opening and reading the thread makes no difference. It's always unread.

But really what I'd like is a global mark-all-threads-as-read feature for a given channel [and an API for that, for another chat client I'm also using, ruqola].

grisu48 commented 3 years ago

I'm also affected by this bug. It would be great to have somewhere in the thread display an additional button "mark all as read" to manually get rid of this.

shaiton commented 3 years ago

Still occuring in version 3.9.0

OloBo-MSK commented 3 years ago

Same problem

grisu48 commented 3 years ago

What helped for me was to Select unread->all->unread in the thread display.

I'm observing that the displayed unread threads were not the actually unread threads. So first selecting all and then going back to unread reveals the actual unread threads and once they are opened, the unread notification goes away.

Hope this helps you as well :slightly_smiling_face:

dimitrihof commented 3 years ago

What helped for me was to Select unread->all->unread in the thread display.

I'm observing that the displayed unread threads were not the actually unread threads. So first selecting all and then going back to unread reveals the actual unread threads and once they are opened, the unread notification goes away.

Hope this helps you as well slightly_smiling_face

Thanks for the workaround, but that isn't something you can tell every user to do on a big instance.

PvUtrix commented 2 years ago

Definitely some bug, seeing this for the first time in a deployment with over 100k messages.

Clicking "mark read" on the username menu doesn't help to clear thread notification. image Filtering the threads by unread returns empty. version 4.8.3 image image

PvUtrix commented 2 years ago

Rocket chat got updated to 5.2.0 and I still can't clear this stuck thread notification :(

PvUtrix commented 2 years ago

Dear Rocket Chat team, this issue is over 2 years old and still present 2 major releases later. Any plans to fix this?

This is terribly annoying to see a notification and not being able to clear it. I'm on version 5.2.0 now and it's still there

SlowMo24 commented 1 year ago

The workaround by @grisu48 (https://github.com/RocketChat/Rocket.Chat/issues/19077#issuecomment-743115969) is not working for me. Is there something an admin could do to solve the problem from the back-end?

SlowMo24 commented 1 year ago

so my admins just upgraded to 5.4.1 and that seems to have solved the issue. I think I had to "mark that channel as read" manually.

himani-mehra commented 2 months ago

Hi @shaiton , I would love to take on this issue and contribute to the project. Could you please assign it to me if it's available? Looking forward to your response. Thanks!

AravindAkuthota commented 1 month ago

@shaiton @dfaure-kdab Hey i would like to work on this could you assign it to me

dfaure-kdab commented 1 month ago

I'm no admin here, just a user. But surely you can just make a merge request without this issue being assigned to you?

AravindAkuthota commented 1 month ago

sure will do sorry for the interuption @dfaure-kdab