RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.38k stars 10.49k forks source link

[BUG] Non-latin search issues #19344

Open ankar84 opened 4 years ago

ankar84 commented 4 years ago

Description:

There is a couple bugs in Admin UI - Rooms search (maybe in some other place too, but now I'm talking about Rooms) with non-Latin search query (Cyrillic in my case).

Steps to reproduce:

  1. Enable UTF8 Names Validation on Admin UI - General
  2. Enable Allow Special Characters in Room Names on Admin UI - Layout - User Interface
  3. Create channel and private room with Cyrillic names, like тестовый канал and тестовый чат
  4. Go to Admin UI - Rooms and try to find that room and channel

Expected behavior:

Non-Latin search should work in every search field in Rocket Chat interface

Actual behavior:

UTF8 Names Validation image Allow Special Characters in Room Names image Private room and channel with Cyrillic names image Search attempts image image Transliteration search works fine image image

And a very bad thing - internal transliteration name now not shown in Room Info (it was in 3.1.1 server version) image image

And another one issue is that Discussion check box have AND logic but not OR logic (as it should be) Here is an illustrative screenshot image image

Server Setup Information:

Client Setup Information

Additional context

So, in that issue actually 3 bugs:

@ggazzo and all Front-End team, please take a look at that issue. Thanks!

Relevant logs:

No logs

ankar84 commented 3 years ago

Admin UI - Permissions - owner - USERS IN ROLE - Choose a room same issue image But Add User - works perfect with Cyrillic letters image

damian-centrone commented 3 years ago

This issue is already fixed, you can now search for non latin characters. Tested on 3.8.0

ankar84 commented 3 years ago

@damian-centrone hey! It would be nice if you let me check if that issue is solved or not by myself.

damian-centrone commented 3 years ago

Hello, this was tested on the next release available in a few days. I close the ticket for internal control purposes. When 3.8.0 is deployed and if you have the same issue, I can reopen.

ankar84 commented 2 years ago

@damian-centrone actually issue is here on 4.3.3 image image image

ankar84 commented 2 years ago

Still an issue in 5.0.3! image image image image image

ankar84 commented 2 years ago

Actually Admin UI - Layout - User Interface - Allow Special Characters in Room Names setting have impact to that search behavior. image

Gummikavalier commented 1 year ago

I think this is again an issue in RC 5.3.2.

Even when Allow Special Characters in Room Names is disabled on our instance, I found out that one user had been able to create rooms with using spaces and Nordic characters (UTF-8). This has probably happened via desktop or mobile client (unconfirmed).

Any of these rooms are now invisible in the admin UI rooms search.

IgorOhrimenko commented 7 months ago

6.6.1 fixed изображение