RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.11k stars 10.36k forks source link

Sidebar - unread button is gone since the upgrade to 3.8.0 #19573

Open ugzv opened 3 years ago

ugzv commented 3 years ago

Description:

Prior to the upgrade (3.8.0), there was a blue button indicator to show you have unread messages and you need to scroll up/down to see them.

Steps to reproduce:

  1. Scroll down in the sidebar
  2. Let someone write a message on some channel, out of your view window
  3. You have no idea there is a new message there

Expected behavior:

  1. The blue button should appear like it used to work in 3.7.2 or some other indicator

Actual behavior:

This is how information is displayed U0rives9k

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

vinceogne commented 3 years ago

I see this issue as well.

Opa- commented 3 years ago

Issue is still present on version 3.8.1

danel1 commented 3 years ago

@ggazzo - confirm - still an issue..

ugzv commented 3 years ago

@ggazzo can this be checked?

ggazzo commented 3 years ago

hey, thanks for the report, but we are aware of the "deletion"... we change the whole sidebar (I hope you notice), and now we are using a virtualist instead of rendering the entire list, which saves us some memory (for users with 2k 3k rooms) and brings some performance improvements... but the old implementation no longer works, it was based on the elements in the list, and since only a partial list is currently rendered... we have plans to reintegrate the feature soon as possible, but not until we finish some other high priorities, so I would ask you not to be upset until it gets done...

btw, I don't believe you should miss any unread, to avoid that I group by unread and I then let the list on the top until we get the 'proper' 'fix'... again, it's not an issue or a bug, we decided to disable momentarily...

again thanks for the report and good to see how people like/miss some features :)

I hope to have good news soon

:v:

aditya-mitra commented 3 years ago

@ggazzo Will developing a new component inside the sidebar folder which says something like 3 unread messages from 2 rooms be good solution? I am working on it.

himani-mehra commented 3 weeks ago

Hi @ugzv , I would love to take on this issue and contribute to the project. Could you please assign it to me if it's available? Looking forward to your response. Thanks!