RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.08k stars 10.35k forks source link

[BUG] PUSH from encrypted channel or direct message is not working properly. #20142

Open amezioud opened 3 years ago

amezioud commented 3 years ago

Description:

When we try to send a message from an encrypted channel to a disconnected or absent user, the message content is visible on the pop-up on my android smartphone. Even if all three privacy options are unchecked. On the other hand, no content displayed when sending is done from an unencrypted channel.

Steps to reproduce:

  1. Go to Administration --> General --> Site URL" and Change content from http://localhost:3000 to https://rc.your_domain and save it.
  2. Go to Setup Wizard and accept "Cloud Service Privacy Terms Agreement" and save it.
  3. Go to Connectivity Services and register your workspace on https://cloud.rocket.chat.
  4. Disable privacy options in push parameters.
  5. Create a private and encrypted channel.
  6. Invite a another user.
  7. Send a message to him.
  8. The encrypted messages will no longer go hidden.

Expected behavior:

should not display the content of the message, only that "there is a message".

Screenshot_20210110-211304_One UI Home

Actual behavior:

The content is displayed. It's too bad :(

Screenshot_20210110-211821_Tutanota

Server Setup Information:

Client Setup Information

Additional context

applications engine version : 1.21.0-alpha.4235 update of the DB : 212

Relevant logs:

I20210110-20:16:40.678(0) API ➔ debug Success { statusCode: 200, body: { message: '{"msg":"result","id":"262","result":{"_id":"wT84mJyXy6pWYND96","rid":"AazP98BQJzX7zoybz","msg":"eyJhbGciOiJBBUsWSeexr/1tIXvA+5z4d3oRMCkS9f+RPUPBNqGVildGDCzZCGs2qGztMJGUWH4e9Sdyn/m7F1QqBx6NpBGTYFMOrZnqUcce0xYMi3D+W5WmVjjtMA6w3Ts/vCGhHmn6gihPeWt4HsBE6dO90yX3Glf+TR3OxLwT+uCAymnGjcs=","t":"e2e","e2e":"pending","ts":{"$date":1610309800632},"u":{"_id":"GDJrGMvh7EZtZPAuc","username":"rc.admin"},"mentions":[],"channels":[],"_updatedAt":{"$date":1610309800669}}}', success: true } }

amezioud commented 3 years ago

I just tried the version 3.9.3 and it's the same behavior.

amezioud commented 3 years ago

I think I figured out how to reproduce the problem.

If you change the Site URL in "Administration/General" from http://localhost:3000 to https://rc.your_domain and you register your workspace on https://cloud.rocket.chat, the encrypted messages will no longer go hidden. For this to work, you must leave the url name on http://localhost:3000 and register it.

Unfortunately it will no longer be possible to redirect your users to your domain name in an email notification.