search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.4k stars 10.51k forks source link

Allow Reacting - Editing Private Room - Clears Settings, Doesn't Save. #20322

Closed BizClimb closed 3 years ago

BizClimb commented 3 years ago

Note: I'm putting multiple bugs in the same bug report because I feel like they are all related.

Bug 1: When editing a "read only" public channel, the Allow Reacting option does not show when toggling the Private option, you need to save it then reload the edit room form to see it (the same goes for when un-toggling private, it does not disappear).

Bug 2: If you attempt to turn on Allow Reacting in a read only public room and save, then re-edit the room, the option is still un-toggled, and it also clears out the "Hide System Messages" toggled options you had checked before.

Expected behavior:

Allow Reacting should be hidden/shown based on Private option being toggled on or off.

Allow reacting should turn on when you clicked save if it was toggled on, and the checked items in Hide System Messages should be retained and not cleared out.

Actual behavior:

Allow Reacting does not stay on and it also clears the Hide System Messages setting.

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

close-issue-app[bot] commented 3 years ago

This issue was closed because it does not use our bug report issue template.

Please make sure to use it and fill it as much as you can so we can provide better and faster support.

The following sections must not be removed, or else the BOT will close it immediately again: