RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.4k stars 10.51k forks source link

Hotchillee - Slack import making content disappear #20688

Closed tom-gouldson closed 3 years ago

tom-gouldson commented 3 years ago

Context Hotchillee is looking to move its Digital cycling club communications from Slack to a Rocketchat based app. In doing so it hopes to maintain the user experience as much as possible so as not to confuse its user base while using Rocketchats white labelling capability to give it Hotchillee brand and feel. As part of this Hotchillee looks to retain all the historic chat from Slack to make it as seamless as possible for users transferring to the new platform (similar to when Facebook does a major UX overhaul - all the data remains but the look and feel is different and new features are added but it’s still familiar enough not to alienate users).

Description of bug:

Some imported Slack data appears to be triggering a bug wherein content suddenly disappears when a user clicks 'Thread' anywhere in that channel. That is to say the content is still on Rocketchat (others users can see it) but once a User clicks ‘Thread’ the channel goes blank and can only be recovered through refreshing the screen in Browser or re-installing the Hotchillee App on mobile.

This was diagnosed as a Slack import issue through the following steps:

  1. Imported the slack export to 17th Dec (the last import before the problems began). The import worked fine, and there were no issues with channels or threads with disappearing content.
  2. Next we tried a full incremental import of slack data to Feb 1st. It complained of a duplicate record and failed to complete the import. That means incremental overlapping imports no longer work (see separate bug).
  3. Then we rebuilt the install of rocket back to brand spanking new again and imported the full slack export to 1st Feb. It imported fine, but the content in threads disappearing is back.

Steps to reproduce:

  1. Go to https://community.hotchillee.cc/channel/general_chat
  2. Click on 'Thread' anywhere
  3. Content should have disappeared

Expected behaviour:

The thread to appear in the side panel and the main content to remain in the main panel and stay there.

Actual behavior:

Content disappeared (see attached video).

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

Javascript console error: db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 TypeError: Cannot destructure property 'username' of 'e' as it is null. at db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1814 at Array.filter () at db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1814 at String.replace () at replaceUsers (db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1814) at r.parse (db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1814) at m (db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1814) at eval (/app/threads/client/components/ThreadComponent.tsx:1) at Object.Ma [as useMemo] (db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401) at r.useMemo (db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1377) wf @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 Ff.r.payload @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 Oc @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 nf @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 ji @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 Hi @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 Ui @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 Ai @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 (anonymous) @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 r.unstable_runWithPriority @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1419 sc @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 _c @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 dc @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 Xi @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 r.unstable_runWithPriority @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1419 sc @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 Ki @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 (anonymous) @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1401 z @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1419 k.port1.onmessage @ db742d1d32bcad874d80b83e57e68ec8c9ebd1e2.js?meteor_js_resource=true:1419

https://user-images.githubusercontent.com/78903354/107620676-f9407f00-6c4c-11eb-874a-f2f5a59e9d0f.mov

close-issue-app[bot] commented 3 years ago

This issue was closed because it does not use our bug report issue template.

Please make sure to use it and fill it as much as you can so we can provide better and faster support.

The following sections must not be removed, or else the BOT will close it immediately again: