search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.67k stars 10.66k forks source link

Making Discussion Channel to favourite #21041

Open ABHAYJAIN2601 opened 3 years ago

ABHAYJAIN2601 commented 3 years ago

Description:

If user try to add discussion channel to favourite It don't show any pop-up/message if user is not the part of that Discussion channel

Steps to reproduce:

  1. Try to add any Discussion channel to your favourite (that you are not part of it)

Expected behavior:

At-least we can show any kind alert like pop-up/message

Actual behavior:

it's look like kind of error why i can not mark it favourite

https://user-images.githubusercontent.com/51324264/110456821-02a7f480-80f0-11eb-8e23-4f2fc9cd9eec.mp4

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

ABHAYJAIN2601 commented 3 years ago

I started looking into this issue. If you have any other idea please share it here!

ABHAYJAIN2601 commented 3 years ago

@dougfabris Please review this !

Darshilp326 commented 3 years ago

@ABHAYJAIN2601 Hello! I think you must be part of the room to favorite it!

ABHAYJAIN2601 commented 3 years ago

@Darshilp326 Yeah! but if user get pop-up message to show it will look more better right?

himani-mehra commented 2 months ago

Hi @ABHAYJAIN2601 , I would love to take on this issue and contribute to the project. Could you please assign it to me if it's available? Looking forward to your response. Thanks!