RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.02k stars 10.32k forks source link

WebRTC not working #2122

Closed jcardila closed 1 year ago

jcardila commented 8 years ago

I can't get webrtc calls to work, tried on own server and on RC demo server and couldn't get them to work. Both pass the webrtc test except for IPv6 and a warning in Reflexive connectivity. Tried connected in the same network and on different networks.

Sing-Li commented 8 years ago

I have experienced the same thing with the demo server, only since the CPU prob. @rodrigok Do you think it might be related to this change? Thx

https://github.com/RocketChat/Rocket.Chat/commit/cd829c3f92ab6ef2bca8270afbfddadf2ad7eacc

rodrigok commented 8 years ago

@Sing-Li probably yes, we need some time to improve that

ma-karai commented 8 years ago

Indeed, since i updated to 0.17.0 WebRTC does not seem to work.

I am aware that the webRTC functions are not really a priority at the moment. But if there would be a possibility to include a settings button to change voice activation levels, or include a utilize push to talk button, that would be greatly appreciated.

realAkhmed commented 8 years ago

Same here. WebRTC problems in 0.17.0 @bott0r what was the previous version that you used when WebRTC worked?

ma-karai commented 8 years ago

@realAkhmed for me it was 0.15 or something. I am currently on the developer version.

xenithorb commented 8 years ago

Im having the same issues... Broken since Feb? I take it no one actually uses this to talk to people then

thomas-mangin commented 8 years ago

Yes, it is broken (which is annoying). It does not seems to be tested when releases are done.

xenithorb commented 8 years ago

Are there plans to get this working again? Or drop the feature advertising from the home page?

I large part of why I spent the time to deploy this was to do WebRTC calling...

jeromeza commented 8 years ago

Same here - been playing around trying to get this working for a day or two now - only to find out its still broken. What version is the demo running as it works on there?

xenithorb commented 8 years ago

Perhaps this will help some people:

xenithorb 2:39 PM @frdmn: I'm sorry, but I just realized that WebRTC audio does work between two of the reference electron clients. It seems my earlier failures to get it to work were due to doing LAN->LAN testing with a server that existed on the public internet. We could not however get video to work. Electron also needs to be able to anchor to an audio device, like firefox/chrome. Otherwise it worked really well 🙂 Perhaps the information warning should include something about not trying to contact in-LAN other clients while using an external server? Perhaps the default TURN/STUN settings mess the ability to do that up?


I wrote that in #support on the demo server earlier.

jeromeza commented 8 years ago

I still can't get audio / video to work.

My server is external from my network. Clients are also on different networks.

I just get call popups, answer and nothing happens.

thomas-mangin commented 8 years ago

Same here - all clients and the server are on real word IP (ie: no NAT anywhere). The server is however firewalled only allowing port 443 (the TURN/STUN server is on another IP).

thomas-mangin commented 8 years ago

0.32 works for me.

jmls commented 8 years ago

we can't seem to get this working at all - we're running 0.33 in docker . If I call a friend, nothing happens. if he calls me, the popup appears - but I click accept nothing happens

image

thomas-mangin commented 8 years ago

It has all the characteristics of a NAT issue. Make sure STUN is correctly setup.

jmls commented 8 years ago

ah - ok - do we need to set up our own STUN server then ?

xenithorb commented 8 years ago

Thing is, I've never been able to get "Reflexive connectivity" to work tested by http://test.webrtc.org

That seems to be causing some issues, other issues like when a call doesn't work, the other party isn't really notified if their client thinks they're in a call are clearly event-driven bugs of the product. There are a lot of errors here, and it's only compounded by trying to be compatible with many browsers (Which should be commended, I'm just saying though)

On Linux, with the reference client, I am able to make calls (and do frequently), but only works on occasion from recent versions of chromium, and doesn't seem to work at all on Firefox.

Screen sharing is a really odd one, too. In this case it doesn't work in the reference client because they haven't yet figured out how to get the extension to work in Electron. Firefox doesn't show a video feed because the selector never appears. And Chromium you can select the viewport to share, and that works to include an image of your desktop where you would expect video to be, but the other end only sees black.

Video is the same way, I imagine for the same reasons. Black on the other end.

thomas-mangin commented 8 years ago

@jmls

root@stun:~# dpkg -l | grep -i turn
ii  resiprocate-turn-server             1:1.9.7-4~ubuntu14.04.1          amd64        reSIProcate SIP stack - ICE/TURN server
jmls commented 8 years ago

@thomas-mangin thanks for the info - However, I would have thought that if this were needed it would have been supplied and installed on the official rocketchat docker image though .. or am I being thick ?

xenithorb commented 8 years ago

I'm personally targeting coturn through an ansible role I'm in the process of writing

thomas-mangin commented 8 years ago

@jmls I installed rocket-chat 'by hand' (well, with my own scripts) so I have no idea what the docker image looks like but I would not assume they done it.

Sing-Li commented 8 years ago

New chat-centric non-intrusive solution testing this week.

On https://demo.rocket.chat

When you are in a Direct Message or Private Group. You will notice a new video button on the toolbar , it might be glowing to indicate a video session is going on, just click it anytime to join a video conference with all those in the room

One click - and no annoying messy dialogs that pop up and won't go away

jmls commented 8 years ago

@Sing-Li : is this something that's going to replace the existing audio/video ? (ie should we be wasting time trying to solve the problems that we are having now on 0.33?)

Sing-Li commented 8 years ago

Very likely. But we're not ready to make any official statements just yet.

Meanwhile, please try things out and give us as much feedback as possible. We expect the new solution's stability and robustness to be improved several folds (it makes close-to-impossible-to-configure large group video finally possiblel), and hopefully the learnt-from-feedback UI/Ux is actually superior as well.

jmls commented 8 years ago

excellent news. We will want it to work in docker behind an nginx proxy - so that's something to bear in mind :)

It would also be very useful to have an icon to start the conference with audio-only - I hate having to scrabble to turn the video off ...

Sing-Li commented 8 years ago

Yes on both counts - not immediately on switch-over ... but already on TODO :)

jmls commented 8 years ago

cool. how long do we have to dream before this becomes a reality - unofficially of course ...

Sing-Li commented 8 years ago

haha ... you might have to DM one of us on the demo to get an OTR message on a vapor estimate 😀

In true FOSS fashion ;-)

jmls commented 8 years ago

ohhh! testing otr as well ;) will do ..

MarekPikula commented 8 years ago

I had similar problems with STUN/TURN and found list of pretty reliable servers somewhere on Stack Overflow, which work for me. Here it is:

stun:stun01.sipphone.com,stun:stun.ekiga.net,stun:stun.fwdnet.net,stun:stun.ideasip.com,stun:stun.iptel.org
jmls commented 8 years ago

you tease !!

MarekPikula commented 8 years ago

Sorry, sth went wrong with Markdown.

jmls commented 8 years ago

any news on the new feature ?

xenithorb commented 8 years ago

It was released (in beta) as a feature on the stable 0.34.0 version. Check the changelog.

propertunist commented 8 years ago

i'm testing the current public version of rocket.chat here and also unable to get any webrtc connections going. i am seeing the same behavior as above - the call initiates, but no streams are shared, so no call occurs. how do i find relevant error messages from rocketchat to help diagnose the issue? i see nothing in the terminal i am running rocket chat from. thanks

johnfelipe commented 8 years ago

webrtc

Versión 51.0.2704.106 m (64-bit) of chrome

nothing happend

firefox

test

asthomasdk commented 7 years ago

What is the overall status of these features?

We are using the audio for calls on a daily basis - but often have problems with echos and with the call quality dropping and having to restart calls. When it works though - the sound is very good and clear.

We have not been able to use the screen sharing - and this is a feature that we are anxiously waiting for. Once that works well - people will be able to drop things like GoToMeeting and just do everything in Rocket ;-)

Any insight into where you think you are with this and current plans for moving past beta would be great to have.

propertunist commented 7 years ago

@asthomasdk - any insights you can provide as to how you got even the audio to work would be helpful to me as i have never seen the audio or video to work in my rocketchat install. thanks

childnode commented 7 years ago

/link #2122 to #4846

hadifarnoud commented 7 years ago

I can't figure out why this isn't working for me. tried WebRTC settings people said here too

screen shot 1395-12-21 at 8 51 04 pm
hadifarnoud commented 7 years ago

this issue been open for months!!!

frdmn commented 7 years ago

Because we don't prioritize issues based only on the creation date. Read up the relevant issues regarding WebRTC and you'll understand why this one is still open.

Von meinem iPhone gesendet

Am 11.03.2017 um 18:28 schrieb Hadi Farnoud notifications@github.com:

this issue been open for months!!!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

hadifarnoud commented 7 years ago

I've read #4846 but still don't know why this issue is still open. can you please tell us why @frdmn ?

frdmn commented 7 years ago

@hadifarnoud Simply because no-one came up with a proper and advanced solution for this. If you can help out, you're very welcome to do so.

hadifarnoud commented 7 years ago

I get this error when clicking on mic.

getUserMedia() no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.

https://sites.google.com/a/chromium.org/dev/Home/chromium-security/deprecating-powerful-features-on-insecure-origins

I guess that's because I have RC on http (without SSL)

alirezaimi commented 6 years ago

I installed 0.58.2 and mic and video call and direct call not work in android or desktop or web interfaces .

Alseenrodelap commented 6 years ago

The call and video call functions still don't work. Do I have to setup something, or open ports?

HammyHavoc commented 6 years ago

Yep, having issues with this too. I click accept on the call and then nothing.

bse5 commented 6 years ago

same here ... Accept and nothin happens

TerrenceLP commented 6 years ago

Unable to get property 'user' of undefined or null reference SCRIPT438: Object doesn't support property or method 'createMediaStreamDestination'

This using a Paid TURN/stun twilio servers over https