User Online Status stays "Offline" after internet outage

[wreiske]

Description:

The user's status stays "offline" and can't be changed to "online" after the internet connection is interrupted. This can be due to a VPN dropping, the internet going out, bad WIFI, etc....

When the internet comes back and the user reloads the page, their status shows as "offline" and can't be changed to "online" without first setting it to away and then back to online.

Steps to reproduce:

1. Visit open.rocket.chat

2. Open DevTools

3. Go to the Network tab and set the network state to "offline." This effectively emulates what happens when the internet goes out.

4. Wait a few moments, maybe a minute just to be sure, and then click around into another channel. You'll see an "undefined" error here and the channel will fail to load.

5. Realize "oh, my Wi-Fi disconnected" or "Oh! My VPN Dropped!" and reconnect. In this example, we'll just set the network state back to "Online"

6. Now that you're reconnected, hit View -> Reload.

7. Your status is now stuck "Offline"

Expected behavior:

After reloading, the status should be Online!

Actual behavior:

See step 7 above.

Server Setup Information:

• Version of Rocket.Chat Server: open.rocket.chat (3.14.0)
• Operating System: N/A
• Deployment Method: N/A
• Number of Running Instances: N/A
• DB Replicaset Oplog: N/A
• NodeJS Version: N/A
• MongoDB Version: N/A

Client Setup Information

• Desktop App or Browser Version: 3.1.1
• Operating System: Windows 10

[tobias-mierzwa]

Same problem here.

Server Setup Information:

• Version of Rocket.Chat Server: 3.14.0
• Operating System: Ubuntu 18.04
• Deplayment Method: https://docs.rocket.chat/installation/manual-installation/updating
• Number of Running Instances: 1
• DB Replicaset Oplog: N/A
• NodeJS Version: v12.18.4
• MongoDB Version: N/A

Client Setup Information

• Desktop App or Browser Version: Firefox 88.0 (64-bit)
• Operating System: xUbuntu 20.04

[ugzv]

Same problem here. My status appears offline, when I am present. Refreshing/reloading the Windows client doesn't help.

[xadhoom]

For some reason internally it thinks that you're online, so it does not do the transition online-online. If you select busy or away it changes correctly and after is possible to select back to online.

Happens also on https://open.rocket.chat .

[zaphod534]

It looks like a synchronization problem, as the user status (and statusConnection) in the db is correct. After some investigation, I noticed that the client fetches user information on startup, but by that time the user has not yet been updated on the server.

By adding a delay here the problem seems to no longer occur.

[zaphod534]

Getting user's data in Accounts.onLogin callback seems to solve the issue. @g-thome do you think this is an acceptable solution?

diff --git a/client/startup/startup.ts b/client/startup/startup.ts
index d226716c0..d05e635bc 100644
--- a/client/startup/startup.ts
+++ b/client/startup/startup.ts
@@ -37,7 +37,7 @@ Meteor.startup(() => {
        window.lastMessageWindowHistory = {};

        let status: UserStatus | undefined = undefined;
-       Tracker.autorun(async () => {
+       Accounts.onLogin(async () => {
                const uid = Meteor.userId();
                if (!uid) {
                        return;