search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.07k stars 10.34k forks source link

[Livechat] Don't allow transferring chats to inactive departments #21954

Open cuonghuunguyen opened 3 years ago

cuonghuunguyen commented 3 years ago

Description:

On the UI, it is only possible to select the active departments to transfer the livechat room but we still can transfer the chats to the inactive departments by api/v1/livechat/room.transfer. This will let the visitor transfer the room to the test/internal/private department on Rocket.Chat.

Steps to reproduce:

  1. Deactivate the department
  2. Use api/v1/livechat/room.transfer to transfer the room to the inactive deparment

Expected behavior:

Error returned, could be department not found or department is inactive

Actual behavior:

Room transferred successfully

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

johncrisp commented 3 years ago

Thanks for reporting this.

Should this be in the Livechat/Omnichannel repo? I can move it if so.

cuonghuunguyen commented 3 years ago

hi, its the bug in the API, not the livechat widget