search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.04k stars 10.33k forks source link

File Upload Error + Bad Words Filter #22918

Open theoprata opened 3 years ago

theoprata commented 3 years ago

Description:

Before upgrading to 3.17.0, the file upload feature was working flawlessly. Users were able to drag and drop pictures and other types of files. As soon as I deployed the 3.17.0 update, our users started complaining about an error they get when they were trying to upload a file.

Steps to reproduce:

  1. Open any message window (Group or private)
  2. Upload any type of document (We use a lot of screenshots for sharing issues)
  3. An error "Cannot read property of "0" null" will occur

Expected behavior:

In the previous version, it was working as expected.

Actual behavior:

In the new version, it would give the user an error for any type of file upload.

Server Setup Information:

Client Setup Information

Additional context

By checking the log, I was able to pinpoint the issue to make it work. It seems that issue is tied to the bad words filtering feature as shown in the log below. In a corporate environment, the bad words filtration is a must.

Relevant logs:

image

This was from my staging server.

ankar84 commented 3 years ago

Related to https://github.com/RocketChat/Rocket.Chat/issues/22853 and https://github.com/RocketChat/Rocket.Chat/issues/22831 Don't close that issue, it should be resolved by RC Team.

debdutdeb commented 3 years ago

Theo 👋🏼

Thanks for reporting this. This is indeed a legit problem. I'll talk to product and update you all asap.

yashovardhan commented 3 years ago

Hey there,

We talked about this with the product team. The bad words filter is being deprecated in the following release and is being converted into a RC App (which will also be shipped alongside).

This issue will automatically be resolved henceforth 🙂

ankar84 commented 3 years ago

We talked about this with the product team. The bad words filter is being deprecated in the following release and is being converted into a RC App (which will also be shipped alongside).

Nice solution!