search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
39.51k stars 10.12k forks source link

Incorrect avatar for Gitlab integration webhook #23161

Open ddv88 opened 2 years ago

ddv88 commented 2 years ago

Description:

Avatars from Gitlab doesn't appear correctly.

Steps to reproduce:

https://docs.rocket.chat/guides/administration/administration/integrations/gitlab

Expected behavior:

Avatar bot or repository avatar should be appear.

Actual behavior:

For some reason avatar is replacing by admin avatar url (daniil in my case), but its incorrect, and image is not visible, but img alt tag has username in it. User for gitlab has correct avatar image.

![Rocket Chat - httpsrocket-chat unictech ru](https://user-images.githubusercontent.com/8138405/132753639-57fe30d9-554a-4553-9c10-368192483a5d.png) ![Rocket Chat2 - httpsrocket-chat unictech ru](https://user-images.githubusercontent.com/8138405/132753681-f11b4e0b-38ce-479d-97ba-4191b02a44ab.png) ![Rocket Chat5 — Яндекс Браузер](https://user-images.githubusercontent.com/8138405/132753700-99f442fa-9293-4246-ac6d-1ef94ed214bb.png)

Server Setup Information:

Deployment Version 3.18.1 Apps Engine Version 1.27.1 Node Version v12.22.1 Database Migration 232 (september 8, 2021 5:32) MongoDB 4.0.26 / mmapv1 (oplog Enabled) Commit Details HEAD: (73ab3c26a) Branch: HEAD OS: Debian 10

Client Setup Information

debdutdeb commented 2 years ago

HI, thanks for reporting this.

I'll investigate this in a little while and get back to you.

eengstrom commented 4 months ago

I'd be curious if the OP, @ddv88, found a workaround, or if this is still the case. In our situation, users who use the electron client have the same behavior as the OP, but in-browser users get the proper GitLab project/user avatars. I believe this to be the case in our situation since the projects are all private, and thus the electron client is incapable of fetching the avatars while unauthenticated to the GitLab server.

ddv88 commented 4 months ago

@eengstrom As i remember it was docker image bug. When we transferred to standalone version the problem is gone,

eengstrom commented 4 months ago

@ddv88 - "docker image bug" as in if you run the server it in a container, it somehow fails? Sadly, that does not align with my current experience in which the only difference is the client - the Electron client cannot fetch the avatar if the avatar used is behind an authentication page (e.g. inside a GitLab server, in our case), but the browser-based "client" which has already been authenticated to the (GitLab) server can, somewhat obviously, successfully issue a GET for the avatar.

Of course that means that I'm really adding to this issue in the incorrect repository, but this was the closes issue my web search first found.

krims0n32 commented 3 months ago

I have the same issue here in electron desktop and the iOS app. Is there a workaround? I tried changing the bots avatar but it seems to reset itself.