search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.58k stars 10.59k forks source link

Create thumbnails from uploaded images #20907 from v3.18.0 (probably) broke uploaded gif preview #23316

Open 3id0 opened 3 years ago

3id0 commented 3 years ago

Description:

Looks like the feature Create thumbnails from uploaded images (pull request #20907 ) broke the inline preview for some (but weirdly not all) gifs. Users were complaining about the issue so I changed "Administation > Message > Message Attachments > Enable image thumbnails to save bandwith" to disabled (it seems it was set by default to "enabled") and now the problem is gone and every gif is animated on all clients (desktop, web, mobile).

Steps to reproduce:

  1. Drag and drop an animated .gif file from my desktop to a group chat in rocket.chat GUI (in a web browser for instance).
  2. In the new "File Upload" window click "Send" button.

Expected behavior:

Gif animation should playback immediately.

Actual behavior:

Gif doesn't play. Instead only the first frame is displayed as a static image. If you click on the (static) "inline" image preview the "fullscreen" preview will appear (with dimmed background) and this "fullscreen" preview will be animated.

Server Setup Information:

Client Setup Information

Additional context

Maybe this is also relevant?: https://github.com/RocketChat/Rocket.Chat/pull/14086 https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/2975

3id0 commented 3 years ago

poke @KevLehman @sampaiodiego

ankar84 commented 3 years ago

"Administation > Message > Message Attachments > Enable image thumbnails to save bandwith" to disabled

Thanks for that! It brings some bugs and problems to my users.

bseclier commented 2 years ago

Thank you very much @ankar84, it solved our problem here too !