Uploading file bigger than the size limit lead to rocketchat server to stop/crash

Nono-m0le commented 3 years ago

Description:

One of our user (admin rights) upload a big file (2GB) when the limit is set to: at the end of the transfer, (100% uploaded) the server became unresponsive

Steps to reproduce:

set a upload size limit
upload a bigger file than the limit
server crash

Expected behavior:

Message saying that the file is higher than the limit and not start the upload (or stop it when the limit is reached)

Actual behavior:

The rocketchat server went unresponsive, as well as the hosting server (ubuntu).

Server Setup Information:

Version of Rocket.Chat Server: 3.18.1
Operating System: Ubuntu 18.04.6 LTS
Deployment Method: snap
Number of Running Instances: 1
DB Replicaset Oplog: 1
NodeJS Version: 12.22.1 - x64
MongoDB Version: 3.6.14

Client Setup Information

Desktop App or Browser Version: Desktop 3.5.6
Operating System: Windows 10

Additional context

Relevant logs:

Exception in callback of async function: RangeError [ERR_INVALID_OPT_VALUE] [ERR_INVALID_OPT_VALUE]: The value "2482641664" is invalid for option "size"
     at Function.allocUnsafe (buffer.js:383:3)
     at Function.concat (buffer.js:564:25)
     at FileStream.<anonymous> (app/api/server/lib/getUploadFormData.js:18:81)
     at FileStream.emit (events.js:326:22)
     at FileStream.EventEmitter.emit (domain.js:483:12)
     at endReadableNT (_stream_readable.js:1241:12)
     at processTicksAndRejections (internal/process/task_queues.js:84:21) {
   code: 'ERR_INVALID_OPT_VALUE'
 }

CoHarsh commented 3 years ago

Can I work on this issue?

dudanogueira commented 3 years ago

@CoHarsh sure!

I would first try to replicated it under the latest version, and then go from there.

Also, try to answer this questions: Does it happen also using the web version? Mobile too?

Let us know your findings :)

RocketChat / Rocket.Chat