RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.61k stars 10.61k forks source link

[BUG] HEIC picture preview not working in Desktop App / Browser #23638

Open dusatvoj opened 3 years ago

dusatvoj commented 3 years ago

Description:

After upgrade server to debian 11 and mongodb 4.2 there's issue with HEIC images. I can't load HEIC image in browser or in electron desktop app. On android / :apple: phone it works. image

Images uploaded before upgrade works fine

Steps to reproduce:

  1. Post HEIC image
  2. Try to view it in browser or desktop app

Expected behavior:

HEIC loaded

Actual behavior:

HEIC not loaded, even after clicking to retry

Server Setup Information:

Client Setup Information

Additional context

N/A

Relevant logs:

No RC logs here. Firefox says NS_BINDING_ABORTED Clipboard - November 5, 2021 11_35 AM

Chrome says this: Clipboard - 5  listopad 2021 11_38

Don't know what's wrong with the app but it's electron -> Don't think there's smth special.

serviceman commented 2 years ago

@jacotec I understand your point, however we merged RocketChat/Rocket.Chat.ReactNative#3633 and we're releasing a new beta unifying "Take photo", "Choose from library" and "Share extension" in a way that all of them converto to JPG, so the browser can render it. You'll still have access to "Choose file" and send HEIC without any conversion.

We're discussing next steps to improve the UX possibly by implementing a feature like you suggested. Thanks for your inputs.

Will this fix also address the issue of not being able to upload photos on IOS in safari with the latest IOS that I reported 3 months ago? https://github.com/RocketChat/Rocket.Chat/issues/23483

soundstorm commented 2 years ago

@serviceman this is an App-Only fix, nothing on the server changed, so wen application will be unaffected. So your bug won't be solved by this merge request.

ggazzo commented 1 year ago
image
AndrewChau commented 4 months ago

I noticed this format is getting more common with a few phones now.