search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
39.79k stars 10.22k forks source link

Rocketchat 4.3.0 not sending e-mails #24071

Closed michalstys closed 1 year ago

michalstys commented 2 years ago

Description:

After upgrade rocketchat to version 4.3.0, rocketchat stopped sending e-mails (log included)

Steps to reproduce:

Try to send any notification or other e-mail message

Expected behavior:

E-mails are sent

Actual behavior:

E-mails are not sent

Server Setup Information:

Client Setup Information

Relevant logs:

Exception in defer callback: TypeError: Cannot read property 'email' of undefined at app/mailer/server/api.ts:170:44 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12) at packages/meteor.js:550:25 at runWithEnvironment (packages/meteor.js:1286:24)

dudanogueira commented 2 years ago

Referenced Line: https://github.com/RocketChat/Rocket.Chat/blob/4.3.0/app/mailer/server/api.ts#L170

Can you please check if the test email (Admin > Email > Smtp > Send a test to my user) is working for you?

I tried reproducing here, but to no success. Can you reproduce that on a new fresh installed docker?

michalstys commented 2 years ago

(Admin > Email > Smtp > Send a test to my user) option doesn't work either (same error happens).

I have set environment variable in my docker-compose.yml file:

MAIL_URL=smtps://user:pass@my.domain:465/

I tried to set up smtp server at Admin > Email > Smtp too, but that doesn't help.

When I roll back RocketChat version to 4.1.2 e-mails works fine, but when I upgrade to 4.3.0 it stops to work and there's error that I mentioned.

skibbipl commented 2 years ago

Same on my installation. I've upgraded today and I see errors in log: I20220101-19:07:56.002(0) Exception in defer callback: TypeError: Cannot read property 'email' of undefined at app/mailer/server/api.ts:170:44 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12) at packages/meteor.js:550:25 at runWithEnvironment (packages/meteor.js:1286:24)

gobbli commented 2 years ago

Same for me on a fresh 4.3.0 installation. If a user register, he get a mail from the system. 2FA over EMAIL and EMail testing over SMTP Settings in Admin Panel didn't work.

I20220102-20:40:24.856(1) Exception in defer callback: TypeError: Cannot read property 'email' of undefined at app/mailer/server/api.ts:170:44 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12) at packages/meteor.js:550:25 at runWithEnvironment (packages/meteor.js:1286:24)

mosesdd commented 2 years ago

same issue here, afaik this is unsupported but I was able to downgrade to 4.2.2 after editing the migrations collection in mongodb

db.migrations.update({"version":252},{"version":249})

gusdgg commented 2 years ago

I think It's related to this change introduced in 4.3.0 version:

APPS: Add new email event for apps (#23925)

Gavilaan commented 2 years ago

Same problem here. But funny, i have 3 installations running, all installed and updated with the same ansible script. On 1 machine mail is working, 2 others not.

wolbernd commented 2 years ago

It seems that fc9c193ccfa7039ef763828c3324fcf34b23a106 fixes this problem. I set up a local dev instance and sending mails works with the current HEAD.

skibbipl commented 2 years ago

Are there any ways to enable apps framework as a workaround without email TOTP? Maybe disable TOTP temporarily in database?

jazztickets commented 2 years ago

4.3.1 fixed it for me.

skibbipl commented 2 years ago

Yup, also works for me

brknapik commented 2 years ago

Still issue in 4.3.3 version

On dev-tools:

Exception in delivering result of invoking 'login': Error: Invalid Two Factor method
    at m (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1272)
    at d (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1272)
    at 29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1270
    at 29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1079
    at Array.forEach (<anonymous>)
    at l._pageLoadLogin (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1079)
    at Object.userCallback (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1083)
    at o (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1079)
    at r (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1079)
    at n._callback (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1)
Error: No callback invoker for method 2
    at 29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1045
    at Array.forEach (<anonymous>)
    at M._process_updated (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1045)
    at M._processOneDataMessage (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1045)
    at M._livedata_data (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1045)
    at p (29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1272)
    at 29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1272
    at 29ad5156ad3b5e63ea49d9d0b214648b266cb7ca.js?meteor_js_resource=true:1
hugocostadev commented 1 year ago

Hi there, thanks for the contribution! 🚀 💯

Sorry, this error does not happen on the latest and maintained releases.

Rocket.Chat  provides support for, at least, 3 months for each release and 6 months to the latest releases of each major version

I would suggest you update your Rocket.Chat version to the latest stable version, which you can find in Releases Page and, check it HERE the table with versions and End of Life dates.

Questions? Help needed? Feature Requests?