search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.51k stars 10.55k forks source link

Notification text does not show attachement text #24201

Open 1100101 opened 4 years ago

1100101 commented 4 years ago

My Setup

Description

We're using an Incoming Webhook with connection to a Gitlab instance to post messages to a channel. The script we use is a slightly modified version from the one available here: https://rocket.chat/docs/administrator-guides/integrations/gitlab/ Since the messages from the webhook are posted via a "bot", the complete content of the message is stored as attachment (see makeAttachment() method in the script). In function mergeRequestEvent(data), when the text: field of the returned content: element is empty, the desktop notification shows a message " uploaded a file".

This is a regression from older (server?) versions, as previously it would show the text from the attachment in the notification.

Current Behavior

The desktop notification for a message from an Incoming Gitlab Webhook does not display the message text, but "uploaded a file" instead.

Expected Behavior

The desktop notification for a message from an Incoming Gitlab Webhook shall consider the text defined in the attachment part of a message if the message text itself is empty.

max06 commented 4 years ago

I can confirm this issue. Our server got updated this morning, since then I'm getting the same toast notifications where it worked before.

alekdimitrov commented 4 years ago

I can confirm this issue too. Our server is on 3.4.2 track (last snap, Ubuntu 20.04 LTS). This is very strange issue because on mobile version everyting is OK, only on web and desktop version is not. We use a rocket cat bot notification for our #git and #jira channel and this is a big problem because Devs and QA cant view what is fixed or changed immediately. Please fix it.

jeanfbrito commented 2 years ago

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.

Thank you!

alekdimitrov commented 2 years ago

Hi. I did the test. The issue is not solved. So I atached 2 screenshots - first is from mobile client (on this shot everything is OK, and second one is from desktop - missing imortant part of message. Please see the screenshots. We are on 4.3.1 and last MongoDB from SNAP. Mobile client is last version (4.23), desktop client too (3.7.5).

rocket_mobile rocket_desktop

Please fix it. If you think that is not main issue from this ticket please open new one. This is problem for us. Its working OK only on 2.x desktop client.

jeanfbrito commented 2 years ago

On browser this didnt happens too? Seems like a chat problem and not an Electron one.

alekdimitrov commented 2 years ago

On browser this didnt happens too?

Nope. Its not working on browser. Only on mobile client work properly .