Update Emoji library - Githubissues

matthias4217 commented 2 years ago

Description:

Currently, emojis in the emoji picker are limited to Emoji 12. The current set seem to be the one in the npm package emojione (emojione-assets in the dev dependencies). However, this project has been discontinued due to a change of name. It should be replaced by the newer emoji-toolkit package. See more about it in this Readme.

This is of course a minor issue, but I figure it can also be quite easy to fix. Thank you for your time and attention !

Steps to reproduce:

Search for an Emoji 12 or newer emoji, such as 🪓.

Expected behavior:

I would like to have a more up-to-date version.

Actual behavior:

There is no 🪓 in the emoji picker.

Server Setup Information:

Version of Rocket.Chat Server: 4.5.1
Operating System: Varies
Deployment Method: Docker
Number of Running Instances: 4
DB Replicaset Oplog:
NodeJS Version: v14.18.3
MongoDB Version:5.0.3

Client Setup Information

Desktop App or Browser Version: Both
Operating System: Ubuntu 20.04

mpgent commented 2 years ago

I'd like to work on this issue

ankar84 commented 2 years ago

Nice to see new updated emojis in Rocket Chat!

Zishan-7 commented 2 years ago

Hey! I would love to work on this issue.

meerhamzadev commented 2 years ago

Is this issue still available? I would like to give it a try.

matthias4217 commented 2 years ago

This issue is still opened indeed. Feel free to make a pull request I guess !

Illusion47586 commented 2 years ago

Hello @matthias4217 I would like to work on this issue

aliubaidsaifi commented 2 years ago

Hello @matthias4217 I would like to work on this issue please assign it to me.

matthias4217 commented 2 years ago

Hello @matthias4217 I would like to work on this issue please assign it to me.

Hello, I am not a RocketChat maintainer. Feel free to contribute. @kotwani2883 has already opened the PR #25131 but it hasn't been reviewed yet.

adityajangir commented 2 years ago

Hello @matthias4217 , Could you please assign this issue to me.

matthias4217 commented 2 years ago

Hello @matthias4217 , Could you please assign this issue to me.

Hello, I am not a RocketChat maintainer. I cannot assign anyone to it, you're absolutely free to open a Pull Request to work on this issue !

kartikbh6614 commented 1 year ago

I want to work on this issues please assign me this issue .

21SINGH commented 1 year ago

this is my first time here i pushed a commit request , but its showing review required , i dont understand a thing what's going on can anyone please explaine its like that since yesterday

anikdhabal commented 1 year ago

@21SINGH your code required review before merge into the project. Reviews allow collaborators to comment on the changes in pull your requests, approve the changes, or request further changes before the pull request is merged. Repository administrators can require that all pull requests are approved before being merged.

21SINGH commented 1 year ago

@anikdhabal
so then who will review it if the administrator is going to do it , then when will he do it because i posted it yesterday

seniorLikeToCode commented 1 year ago

hi I want to contribute to this , assign me this issue.

LovedeepSingh19 commented 1 year ago

hi I need some help with this issue. When ever i try to update the import emojione to emoji-toolkit it shows no library found. I try to install it with meteor and it get installed but in the end whenever i try to run yarn dev it just keep on crashing the application can anyone help me with this one plz.

MashiatK commented 1 year ago

hi I want to contribute to this , assign me this issue please.

VaibhavAPatil commented 1 year ago

I am interested in this Issue. Can I do Pull Request or you can assign this issue to Me.

nikhil-babar commented 1 year ago

I am interested in solving this issue and can add this new dependency. Please can you assign me this issue.

dsg1320 commented 1 year ago

Hey can you please assign this issue

sachinrastogi12 commented 1 year ago

Hey please assign it to me, I want to contribute.

B1TSH3LL commented 1 year ago

if the issue isn't solved yet, please assign this to me. i would work on this issue.

thekrprince commented 1 year ago

Hi, Please assign this issue to me. I want to contribute.

Jashwanthkanderi commented 1 year ago

does anyone working on this issue cause I can contribute to it @matthias4217

matthias4217 commented 1 year ago

@Jashwanthkanderi There’s a merge request opened here (https://github.com/RocketChat/Rocket.Chat/pull/27782) but it hasn’t been accepted yet.

Jashwanthkanderi commented 1 year ago

@Jashwanthkanderi There’s a merge request opened here (https://github.com/RocketChat/Rocket.Chat/pull/27782) but it hasn’t been accepted yet.

Yeah i don't know why it's been 10+ hrs I think it should be correct , but I may solve this issue

KshitjMaheshwari commented 1 year ago

Hi Please assign this to me. I want to contribute.

adastra-react commented 1 year ago

Hey, I would really like to work on this issue, this is my first time getting into open source.

ranjanmangla1 commented 1 year ago

Hey, if this issue is still open, i would really love to work on this issue. Kindly assign me this issue.

matthias4217 commented 1 year ago

@ranjanmangla1 You don’t need to be assigned on it to work on this issue. This comment also gives some advice. ^^

auspy commented 1 year ago

starting working on this issue

SyedAbuBakerAli commented 1 year ago

Hi, @matthias4217 is this issue still open I want to work on this issue. Can you please assign this to me?

nick2432 commented 1 year ago

can i work on this?

SwapnilSonker commented 1 year ago

is this issue fixed by #27782, if not then I want to fix it.

Asrani-Aman commented 11 months ago

@matthias4217 is this issue fixed? or else I can work on it?

meenakshiiyer2531 commented 7 months ago

Is the issue fixed? if not I would like to work on it

himani-mehra commented 2 months ago

Hi @matthias4217 , I would love to take on this issue and contribute to the project. Could you please assign it to me if it's available? Looking forward to your response. Thanks!