search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.57k stars 10.58k forks source link

Time in the left channels panel will not respect time format chosen by user if language differs from selected in Administration #25034

Open Kyogre opened 2 years ago

Kyogre commented 2 years ago

Description:

Time in the timestamps on the left channels panel will not respect time format chosen by user if language differs from selected in Administration.

Steps to reproduce:

  1. Go to Administration -> General -> set Language to any but English (at least such behavior affects Russian language)
  2. Go to My account -> Preferences -> Message -> set Time Format to 24-hour clock
  3. Go to My account -> Preferences -> set Language to English

Expected behavior:

Left sidebar has 24-hour clock for channel messages (you need Extended type of Display selected to see timestamps).

Actual behavior:

Despite user had set 24-hour clock, timestamps still show time as 12-hours clock (e.g. 3:44 PM instead of 15:44)

Server Setup Information:

Version of Rocket.Chat Server: 4.5.4 Operating System: CentOS Linux release 7.9.2009 (Core) Deployment Method: yum + src Number of Running Instances: 1 DB Replicaset Oplog: NodeJS Version: v14.0.0 MongoDB Version: 4.4.13 / wiredTiger (oplog Enabled) Proxy: nginx/1.20.1 Firewalls involved: iptables, ACCEPT ALL

Client Setup Information

Additional context

Video demo: https://user-images.githubusercontent.com/2260980/161399572-7bbdf1fe-37d7-41af-8765-305d848f4846.mp4

Relevant logs:

-

Kyogre commented 2 years ago

maybe relevant to https://github.com/RocketChat/Rocket.Chat/issues/20386