search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.63k stars 10.64k forks source link

No 'Request Entity Too Large' error when uploading too large file, upload just hangs #25070

Open Kyogre opened 2 years ago

Kyogre commented 2 years ago

Describe the bug There is no error when user uploads too large file, upload progress bar just hangs at 0%. In network logs behavior accompanied by 413 Request Entity Too Large error.

What operating system and which version? Windows 10

Which version of Rocket.Chat (Server)? 4.5.4

Which version of Rocket.Chat.Electron (Electron/Desktop)? 3.8.1

Is there any setting relevant changed? -

To Reproduce Steps to reproduce the behavior:

  1. go to nginx config and set client_max_body_size to some amount (let it be 20M)
  2. open any chat in desktop client and start uploading large (20M+ in my case)
  3. progress bar stays at 0 percent for eternity, no errors, just nothing happens:

ab

Expected behavior Show the user "Request Entity Too Large" error like in browser version:

eb

Additional context -

Kyogre commented 2 years ago

@jeanfbrito hi! If that issue affects only RC.Electron, don't you think it needs to be moved back to RC.Electron repo?

jeanfbrito commented 2 years ago

@jeanfbrito hi! If that issue affects only RC.Electron, don't you think it needs to be moved back to RC.Electron repo?

This is a server issue, not a Electron issue. How it only affects Electron? This don't happens on the browser?

Kyogre commented 2 years ago

yes, it doesn't affect browsers. Only affects Electron. Look at the "Expected behavior" in description.

jeanfbrito commented 2 years ago

Yet, this is a problem in the server. The Electron is just a wrapper that opens the web client and adds some desktop functionalities.