search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.24k stars 10.43k forks source link

Fields Query Parameters not working on livechat rooms list endpoint #25300

Open mkvashennikov opened 2 years ago

mkvashennikov commented 2 years ago

Description:

Fields Query Parameters not working on livechat rooms list endpoint

Steps to reproduce:

  1. Send request with query or fields parameter on endpoint '/api/v1/livechat/rooms'
  2. Returned all rooms without apply query or fields

Expected behavior:

Rooms can be filtered by fields

Actual behavior:

image

Server Setup Information:

dudanogueira commented 2 years ago

Hi!

I have checked on latest code, and looks that query parameter is still not supported: (files have been changing places due to some coding refactoring for monorepo)

https://github.com/RocketChat/Rocket.Chat/blob/f0c37c5a8c904181577b80d239255284ac6a1280/apps/meteor/app/livechat/imports/server/rest/rooms.js#L26

Also, tried to look for other endpoint but it filters by t: "c".

I will mark as bug and raise it with our team.

Thanks for pointing out.

dudanogueira commented 2 years ago

This is the documentation of this API, for reference: https://developer.rocket.chat/reference/api/rest-api/endpoints/omnichannel/omnichannel-endpoints/rooms/livechat-rooms-list

ykabusalah commented 2 years ago

@dudanogueira Could I attempt to fix this issue? And if so, would you mind assigning it to me?

Shofiya2003 commented 2 years ago

I want to work on the issue. Could you please assign it to me.

debdutdeb commented 2 years ago

@ykabusalah @Shofiya2003 feel free to work on this. Please join our #contributors channel and leave me a ping (\@debdut.chakraborty). You can ask me any related questions there.

Shofiya2003 commented 2 years ago

@debdutdeb I was working on the issue. I followed all the steps in the documentation to setup rocket chat locally but when I run yarn build I get this error 'command (packages/ui-contexts) yarn run build exited (129)' . Could you please help me?

Shofiya2003 commented 2 years ago

@debdutdeb I tried pulling the changes but there are some changes in the folder that I did not make. I tried stashing and reverting them but there is an error. What should I do? error: lstat("apps/meteor/.storybook/.eslintrc.js"): Function not implemented

fatal: Unable to process path apps/meteor/.storybook/.eslintrc.js

Cannot save the current worktree state

This it the error which I get after staging and stashing the commits Should I do the cloning process again?

Aashray446 commented 1 year ago

Hi, is this issue still open? Can I start working on it? @debdutdeb

Aashray446 commented 1 year ago

I have explored the codebase related to this issue, currently, I guess instead of query support, custom fields are given to perform any search for custom fields. Am I correct?

coderboy-yash commented 1 year ago

Hi, @debdutdeb is this issue still open I want to work on this issue. Can you please assign this to me?

lokesh-wagh commented 1 year ago

Hey @debdutdeb @dudanogueira is this issue still relevant I mean has it been patched or by-passed in previous version's

Starkz24 commented 2 months ago

Has this issue not been fixed by this PR? May I know why it was closed @dudanogueira ?