Size limit alert not showing

RocketChat / Rocket.Chat

The communications platform that puts data protection first.

https://rocket.chat/

Other

40.51k stars 10.55k forks source link

Size limit alert not showing #27989

Open Sirttas opened 1 year ago

Sirttas commented 1 year ago

Description:

We don't see the size limit alert anymore

Steps to reproduce:

set the upload size limit to 20971520 (20mb)
upload a 45mo file

Expected behavior:

a size limit alert should appear

Actual behavior:

no alert appear

Server Setup Information:

Version of Rocket.Chat Server: 5.4.0
Operating System: docker (debian host)
Deployment Method: docker
Number of Running Instances: 1
DB Replicaset Oplog:
NodeJS Version: v14.19.3
MongoDB Version: 5.0.14

Client Setup Information

Desktop App or Browser Version: mac OS desktop client
Operating System: mac OS

DragonUncaged commented 1 year ago

Hey There Can I work On this.

SANGAAM commented 1 year ago

it can be because of 2 reasons a) The size limit alert is not implemented in your code b)The size limit alert is suppressed About this issue we can use express-validator library Pls assign me this project i can SOLVE this

MewadaAnkit commented 1 year ago

Hey , I want to work on this issue . Can you assign it to me?

DragonUncaged commented 1 year ago

i am already working on it. apology, It is taking time.

hugocostadev commented 1 year ago

No need to ask for permission to fix the issue, feel free to work on it! Just check if someone it's already raised a PR for that (should be linked in this issue). Best of luck 🚀 👏

Questions? Help needed? Feature Requests?

Join our Open Server in the #support channel and feel free to raise a question
Join our Community Forum and search/create a post there
Feature Request: Open an issue in Feature Request repository

cherish2003 commented 10 months ago

I guess this issue is rectified in rocket chat 6.6.0