RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.51k stars 10.55k forks source link

Height of the dropdown list is too big for one item inside Omnichannel hints #28937

Open anikdhabal opened 1 year ago

anikdhabal commented 1 year ago

Description:

Height of the dropdown list is too big for one item in many inputs field.

Expected behavior:

Screenshot 2023-04-17 180250

Actual behavior:

Screenshot 2023-04-17 172120

Screenshot 2023-04-17 172636

Screenshot 2023-04-19 005421

Server Setup Information:

-Version of Rocket.Chat Server: 6.0.0-develop -Operating System: windows 10 -Deployment Method: Gitpod -Number of Running Instances: -DB Replicaset Oplog: Enabled -NodeJS Version: 14.21.2 - x64 -MongoDB Version:5.0.5

Client Setup Information

Additional context

Relevant logs:

thealoneshadow commented 1 year ago

Can i work on this one?

Simer13 commented 1 year ago

@anikdhabal can you give more details as to which file to change or i am thinking of making a new one and setting the dropdown list to change the height dynamically based on the number of options. These following changes can be made in the typescript.

const select = document.querySelector('select')!; const optionHeight = 20; // set the height of each option const numOptions = select.options.length; const maxHeight = numOptions * optionHeight;

select.style.maxHeight = ${maxHeight}px; select.style.overflowY = 'auto';

Aaryan6 commented 1 year ago

@anikdhabal can you give me the page URL of the issue?