RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.67k stars 10.66k forks source link

Files menu ignores new server address #29516

Open olodar opened 1 year ago

olodar commented 1 year ago

Description:

For example, old adress was 10.0.3.171, I sent picture and you can see address 171 1 now, I changed address to 200, link to attachment also changed to 200 2 but in Files menu still old address 171 3

Steps to reproduce:

  1. Send attachment
  2. Change server address
  3. See links in Files menu, they are still coming to old address

Expected behavior:

Links must coming to actual (changed) address, not old

Actual behavior:

Links coming to old address

Server Setup Information:

Client Setup Information

azaki45 commented 1 year ago

Hello, I would like to work on this issue, can you please assign it to me ?

jayesh-jain252 commented 1 year ago

Hi @azaki45 You don't need to be assigned to the issue to work on it. You can just dive right in and start working on it. 🚀

azaki45 commented 1 year ago

@jayesh-jain252 Sure, thank you !

azaki45 commented 1 year ago

I have set up the developer environment locally and it's working fine. I am able to reproduce the issue locally, just a little lost on how to proceed from here. I am a little confused on navigating the code base and getting to the root of the issue, some direction and guidance will be highly appreciated. Thank you!

jayesh-jain252 commented 1 year ago

I have set up the developer environment locally and it's working fine. I am able to reproduce the issue locally

Awesome @azaki45 🚀🙌 If you're facing difficulty understanding which component to look for, a handy tool you could try is the React DevTools Chrome extension. In addition, to get a better grasp of the repository structure of Rocket Chat, you can refer to these docs: https://developer.rocket.chat/open-source-projects/server/repository-structure

Vigneshtropper commented 1 year ago

is this good first ?? i think not (+)

Prem-Semitha commented 1 year ago

@jayesh-jain252 I wanted to know if the issue has been rectified

shashwat-dixit commented 1 year ago

@jayesh-jain252 Hi, I would like to work on this issue.

Abjcodes commented 1 year ago

Hey @jayesh-jain252, is this issue fixed?

jayesh-jain252 commented 1 year ago

Hey there! I'm just a contributor, so I can't confirm if it's fixed, but there's a PR that's been waiting for a response from the maintainers😊

Abjcodes commented 1 year ago

Hey there! I'm just a contributor, so I can't confirm if it's fixed, but there's a PR that's been waiting for a response from the maintainers😊

Alright. Thanks for the clarification.

Shwe234 commented 11 months ago

i will work on this issue

Sanil-Surve commented 9 months ago

Hi, I can solve this problem so I can give you solution of this problem

manu-r12 commented 8 months ago

this seems interesting, would love to contribute. How can i get started?

aryan-17 commented 7 months ago

Hi, this issue seems to be unattended for a long time. I would like to help solving this issue. Looking forward to work with your team.

SahilAnower commented 5 months ago

@olodar Can you confirm if this issue is up for grabs or not?

aryamanpathak2022 commented 3 months ago

@olodar is the issue still open ?

azamshaikh1103 commented 3 months ago

@aryamanpathak2022 Probably not, coz the issue is still open

olodar commented 3 months ago

@SahilAnower @aryamanpathak2022 It was partically fixed: preview shows and I can view attachment, but if I'll try to download file, it still comes to old address so I can't download file which was uploaded to old address.

Shaman20 commented 2 months ago

@olodar Is this issue still open for contribution?

webcrafter011 commented 2 weeks ago

@olodar Is this issue still open for contribution?

apparently it is still open

kavyantic commented 1 week ago

I couldn't reproduce the issue after altering server url, I think the issue has been fixed as I already see the proposed fixes from this pr #29620 in the current version RocketChat:develop.

msudipta888 commented 1 week ago

is this issue till open