search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.38k stars 10.5k forks source link

Ability to remove joined / left channel text #2959

Closed cedemore closed 7 years ago

cedemore commented 8 years ago

I would love if you added an option in the administration panel where you can choose to display when a user joined/left a room. Atleast the users on my server find this distracting / unnecessary.

I think this option would be great to have.

Thanks in advance /Cedemore

Molle500 commented 8 years ago

+1

lunitic commented 8 years ago

Ugly solution: Could it be possible to hide them via CSS.. I see they have a class..

class="message system uj" class="message system ul"

tmace85 commented 8 years ago

+1 ;) Would be a nice option. Its annoying if you have a lot of people in the room.

Molle500 commented 8 years ago

Also shouldn't only be user joined/left. Should be optional to have all those kind of messages like user was promoted to owner/mod or channel name changed by Molle and so on... :)

siomosp commented 8 years ago

+1

timkinnane commented 8 years ago

Probably a solution based on hiding the messages is better than actually preventing them, since some bot interactions are triggered by these special events message types. e.g. Someone entering a room, bot might send a welcome message.

rodrigok commented 8 years ago

@timkinnane You are right, but we can filter messages to not send to client these type of messages, bots will keep listening on message insertion.

lunitic commented 8 years ago

@rodrigok been struggling whole night to try to disable the messages. No luck. My other solution in #3418 does not work anymore. Seems like there been code changes. Any suggestion how to hardcode patch away the user has joined messages. Brain feels like spaghetti carbonara now

jkolhi commented 7 years ago

@rodrigok Me and @lunitic have been struggling hard for many hours to figure out how it works - any pointers that can help us explain the flow? I have been searching in the source but not been able to see the message flow. We want to understand where the messages are inserted, rendered and reacted upon. Any help very much appreciated! (All tests so far has resulted in "Internal server error"...)