Slug-V
commented
1 year ago probably related: meteor/meteor#12732
Open mhaluska opened 1 year ago
Slug-V
commented
1 year ago probably related: meteor/meteor#12732
v-a14
commented
1 year ago probably related: meteor/meteor#12732
Have you fix the issue ?
Slug-V
commented
1 year ago Unfortunately, no.
My instance is stuck in 6.2.12 because this 14.21.4 problem exists in each of 6.3+.
So this will die when 6.2 reaches its EOL.
note: I'm using tar from Gentoo ebuild (edit: this is not official but from overlay. I downloaded this about 10 years ago and incrementally hand-adjusted to newer versions). So it may have some difference. If I realize it, I'll open a new issue.
v-a14
commented
1 year ago Unfortunately, no.
My instance is stuck in 6.2.12 because this
14.21.4problem exists in each of 6.3+.
So this will die when 6.2 reaches its EOL.note: I'm using tar from Gentoo ebuild (edit: this is not official but from overlay. I downloaded this about 10 years ago and incrementally hand-adjusted to newer versions). So it may have some difference. If I realize it, I'll open a new issue.
Can you please explain me, what I have to do in this, actually I am very new to open source, but I have knowledge of js, node, and react.
Slug-V
commented
1 year ago @v-a14 I'm very confused about rocketchat-meteor(or, current RC uses raw Meteor?), so the first question is...
If the answer is NO, updating Meteor or backporting the change (and checking whether it makes a difference or not) is needed. If it's YES, inspecting how the installation tarball is made(CD pipeline?) is needed.
edit: I noticed star.json says "meteorRelease": "METEOR@2.13.3". Why is this happening?🤔
Slug-V
commented
1 year ago I tried:
https://releases.rocket.chat/latest/downloadbundle directorygrep -l -F 14.21.4 -r1 ./returned files:
./.node_version.txt
./star.json
./README
./programs/web.browser/dynamic/app/utils/rocketchat.info.js
./programs/web.browser.legacy/dynamic/app/utils/rocketchat.info.js
./programs/server/npm/node_modules/meteor/ecmascript-runtime-server/node_modules/core-js/.meteor-last-rebuild-version.json
./programs/server/npm/node_modules/meteor/babel-compiler/node_modules/resolve/.meteor-last-rebuild-version.json
./programs/server/npm/node_modules/meteor/accounts-password/node_modules/bcrypt/.meteor-last-rebuild-version.json
./programs/server/npm/node_modules/meteor/url/node_modules/core-js/.meteor-last-rebuild-version.json
./programs/server/npm/node_modules/meteor/ecmascript-runtime-client/node_modules/core-js/.meteor-last-rebuild-version.json
./programs/server/app/app.js
./server/.bundle_version.txtPatching these files may solve this.
Slug-V
commented
1 year ago Finally, I got a temporal solution:
what I did:
bundle folder into bundle2bundle2grep -l -F 14.21.4 -r1 ./chmod -v 644 to all found files (edit: you can use xargs)sed -i -e s/14.21.4/14.21.3/g <files> to all found files (edit: you can use xargs)
sed -i -e s/1.4.0/1.5.0/g ./programs/server/npm/node_modules/gc-stats/package.json to avoid #29600 in 6.6.0)cd ../diff -uprN ./bundle ./bundle2 > fix-nodejs-version.patch./bundle or ./bundle2 from patching file path./bundle2 into ./bundlepatch it and try to install
/etc/portage/patchesThis workaround seems to be needed when every Rocket.Chat update, so this issue stays alive until Rocket.Chat starts using more newer nodejs (edit: see #29658).
Slug-V
commented
9 months ago In 6.6.0, patching is fine, but won't build because one (potentially some) node.js package cannot be downloaded (returns 403).
> gc-stats@1.4.0 install /var/tmp/portage/www-apps/rocketchat-server-6.6.0/work/bundle/programs/server/npm/node_mod
ules/gc-stats
> node-pre-gyp install --fallback-to-build
node-pre-gyp ERR! install response status 403 Forbidden on https://node-binaries.s3.amazonaws.com/gcstats/v1.4.0/Re
lease/node-v83-linux-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not installable for gc-stats@1.4.0 and node@14.21.3 (node-v83 ABI, glibc) (fal
ling back to source compile with node-gyp)
node-pre-gyp WARN Hit error response status 403 Forbidden on https://node-binaries.s3.amazonaws.com/gcstats/v1.4.0/
Release/node-v83-linux-x64.tar.gzI think this should be rehappened #29600 issue, regression in 6.6.0.
Description:
Wrong NodeJS version in package bundle: app/bundle/.node_version.txt
Expected behavior:
NodeJS v14.21.3 in app/bundle/.node_version.txt
Actual
Not existing NodeJS version v14.21.4 in app/bundle/.node_version.txt in tar bundle 6.3.8 and 6.4.0
Server Setup Information:
Client Setup Information
Relevant logs:
Gitlab job: https://gitlab.haluska.dev/containers/rocket-chat/-/jobs/2872