Emoji suggestion overriding the actual intent in input textarea

dakujem commented 1 year ago

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating System

[ ] macOS
[X] Windows
[ ] Linux

Operating System Version

Windows 10

It happens on the web browser too?

Yes, it happens on the web browser too

Rocket.Chat Desktop App Version

3.9.9 (and also 3.1.1)

Rocket.Chat Server Version

6.2

Describe the bug

Instead of the intended emoji 😀, I end up with :fleur-de-lis: text (corresponding to ⚜)

This is just too annoying. In other languages, different emojis end up in the suggestion.

This is even worse when I try to edit the message afterwar sending it - I'm unable to close the autosuggestion with Esc key, becaus the Esc key terminates the editing. rocketchat

How to Reproduce

Type :-D at the end of any message and pres the Enter key

Describe your Expected behavior

I expect the suggestions to only trigger if arrow keys are used and one is selected or Tab key are preseed, not when I hit Enter key which is used to send the message.

Anything else

No response

Are you willing to submit a code contribution?

[ ] Yes, I am willing to submit a Pull Request!

dakujem commented 1 year ago

And yeah, I forgot to mention, that the VERY first emoji that pops up after typing : is two kissing men. This is very professional indeed to send to my boss or anyone in fact just type in

The problem is this:
Blah blah

End end up sending fantaqstic!

dakujem commented 1 year ago

I would personally like to turn off the emoji suggestions, because I'm able to use the native OS emoji input. But I do not want to turn off the emoji rendering. This is currently not possible, at least was when I last checked.

Even with these options, the suggestion pops out after typing : ...

Maybe this issue should be renamed to "emoju suggestion window interfers" and the solution would simply be to rpovide an option to disable it completely.

pierre-lehnen-rc commented 1 year ago

And yeah, I forgot to mention, that the VERY first emoji that pops up after typing : is two kissing men. This is very professional indeed to send to my boss or anyone in fact just type in
The problem is this:
Blah blah
End end up sending fantaqstic!

Though the random emoji order itself wasn't fixed yet, the current rocket.chat version will no longer show any emoji suggestion with just a : (though it does with +:)

marcelorafaelfeil commented 1 year ago

I can work on this item if no one is.

dakujem commented 1 year ago

Thanks for reacting so quickly. It has been pestering me for some time, I was just too lazy to report the issue :-)

akshayw1 commented 1 year ago

I can work on this, Pls assign

debdutdeb commented 1 year ago

I wonder .. maybe instead of another setting to disable suggestion, it could be that any suggestion isn't automatically selected and replaced upon hitting enter. Possibly have that happen with a tab press if somebody wants to select a suggestion through keyboard. Otherwise leave the textarea alone.

then if you really want to hide, could use custom css to do that

dakujem commented 1 year ago

That would solve the issue, indeed. I still think that being able to disable the suggestion popup is a good idea. I'm using Rocketchat in proffesional environment ... and frankly ... I don't really need emojis. If I do, I know how to access them.

Interesting fact: Since I disabled the emojis in the account options, I can no longer open the emoji selector (it's disabled). I still get the suggestions popout I reported in this issue, though.

dakujem commented 1 year ago

To summarize, it would be awesome, if the following was implemented:

added option to enable/disable "Autosuggest emojis while typing"
do not select emoji automatically, wait for arrows to select one
switch trigger key to tab to insert the first available emoji (tab is much less used than enter key in chats)
remember the user's most used or last used emojis and suggest them in that order for : (or at least change the default/first emoji to :slightly_smiling_face:)

dakujem commented 1 year ago

It seems now there have been 2 improvements since my original post:

at least 2 characters need to follow : to trigger the suggestion, no more kissing men, yay!
I am able to hit escape key to hide the suggestion without escaping the input window

The funny matching of :-D or :-P still persists, but does not bother me personally so much.

gudia18 commented 9 months ago

Nice catch✌️I am working on this issue

RocketChat / Rocket.Chat