RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.4k stars 10.51k forks source link

Markdown hyperlink syntax #31766

Open Zzzenk opened 10 months ago

Zzzenk commented 10 months ago

Search before asking

Operating System

Operating System Version

No response

It happens on the web browser too?

Yes, it happens on the web browser too

Rocket.Chat Desktop App Version

3.9.11

Rocket.Chat Server Version

6.4.5

Describe the bug

If to type between two hyperlink any text in square brackets it's broke markdown.

Example:

## [v2023.12.21.3](https://https://github.com/)
- [BUG #11111](https://https://github.com/) - [BACK] changelog description
- [BUG #22222](https://github.com/) - changelog description
- [BUG #33333](https://https://github.com/) - [BACK] changelog description
- [BUG #44444](https://github.com/) - changelog description

image

How to Reproduce

  1. Copy and paste followng text to any chat:
    ## [v2023.12.21.3](https://https://github.com/)
    - [BUG #11111](https://https://github.com/) - [BACK] changelog description
    - [BUG #22222](https://github.com/) - changelog description
    - [BUG #33333](https://https://github.com/) - [BACK] changelog description
    - [BUG #44444](https://github.com/) - changelog description
  2. See broken markdown

Describe your Expected behavior

No response

Anything else

No response

Are you willing to submit a code contribution?

preeesha commented 10 months ago

Hey @jeanfbrito, I see this as a major flaw in both the user experience and system. According to me, it's an important fix to make in the upcoming releases of the platform.

I would love to be assigned to work on this issue.

Thanks for the support, Prisha

jeanfbrito commented 10 months ago

You dont need to be assigned to work on this, I will be waiting for your PR.

On Wed, Dec 27, 2023 at 3:13 PM Prisha Gupta @.***> wrote:

Hey @jeanfbrito https://github.com/jeanfbrito, I see its importance as a major flaw in both the user experience and system.

I would love to be assigned to work on this issue.

Thanks for the support Prisha

— Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat/issues/31766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI7PCRKBPOAUHCSEML2G3DYLRQLNAVCNFSM6AAAAABA573GNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQGUZDKNBTGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Atenciosamente, Jean Brito.

preeesha commented 10 months ago

Okay, thanks for the highlight. I am starting to working on this now. Will shortly update you with the progress.

preeesha commented 10 months ago

Hi @jeanfbrito,

I've looked into the issue, and it seems like a bug in the Rocket.Chat's web view's rendering system rather than of the electron app. The problem lies in the code responsible for rendering the messaging web view.

Screenshots:

  1. Here's the code that handles the rendering of Rocket.Chat's messaging web view image
  2. DOM rendering webview image

To fix this, it needs attention in the Rocket.Chat (https://github.com/RocketChat/Rocket.Chat) repository.

Injecting temporary CSS or JavaScript here isn't a good long-term solution.

Please consider escalating this to the Rocket.Chat repository for a proper fix. Let me know if you need more info or help.

Thanks, Prisha Gupta

aryanpnd commented 10 months ago

haha, nice AI response it was @preeesha , any it doesn't solve the issue its only need a small JS fix.

preeesha commented 10 months ago

Ohhh I see the humour rolling @aryanpnd. It's sad to see people getting confused between human and AI responses nowadays. After all, it's the age of AI, I get you it's not your mistake.

Nonetheless, rather than commenting on stuff that doesn't solve the issue, you should just solve the issue. It's highly advisable to maintain professionalism here.

I hope you get the point. And I wish you good luck for your small JS fixes.

Thank you

Giridharan002 commented 9 months ago

Fixed issue RocketChat/Rocket.Chat#31766: Resolved a problem in the Fuselage repository with this pull request: https://github.com/RocketChat/fuselage/pull/1260

Zzzenk commented 8 months ago

@jeanfbrito hi! I saw v3.9.13 was released yesterday, but there is no fix RocketChat/Rocket.Chat#31766. Will it be added in 3.9.14?

jeanfbrito commented 8 months ago

I'm sorry, I closed by mistake. This is an issue with the core, so I will move it to there. It's not the desktop app that does that.

jeanfbrito commented 8 months ago

@dougfabris can you take a look? Seems we have the fix already.

Zzzenk commented 8 months ago

@jeanfbrito hi! Do you know when this fix will be released? I'm really waiting for it))

Zzzenk commented 8 months ago

@jeanfbrito hello?

Zzzenk commented 7 months ago

Anybody?

Zzzenk commented 6 months ago

"Awesome" support... Total ignore...