RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.67k stars 10.66k forks source link

System messages are hidden in RTL languages #32734

Open paymanzafar1 opened 4 months ago

paymanzafar1 commented 4 months ago

Description:

System messages (eg. the message in below image) are hidden in RTL languages like Persian.

Message is shown in English: image

It is not shown in Persian: image

Steps to reproduce:

  1. Set language to Persian
  2. Make a change in any setting that shows a message
  3. The message is hidden below the right side menu

Server Setup Information:

reetp commented 4 months ago

Thanks for reporting.

I'ñl ask someone to take a look.

akshithere commented 4 months ago

Hi @paymanzafar1,

I attempted to replicate the issue locally by setting the user language to various RTL languages, such as Arabic and Persian. In my tests, the system messages appeared correctly when settings were changed. I tested this on version 6.10.0 for local development. Could you please check if you are using the latest version of Rocket.Chat? It’s possible that the issue you are experiencing is resolved in the newer versions.

Thank you for your patience and cooperation.

https://github.com/RocketChat/Rocket.Chat/assets/130065975/01ce564d-dfd9-4932-bfc9-af444974cd43

paymanzafar1 commented 4 months ago

Hi @akshithere, Thank you very much for your reply, and follow up. I am using version 6.9.2, but I do not see the system messages. I will wait for the 6.10.0 version to see if the problem resolves. Thanks again.

paymanzafar1 commented 4 months ago

I think this problem is related to the below issues which are open for a long time:

https://github.com/RocketChat/Rocket.Chat/issues/30095

https://github.com/RocketChat/Rocket.Chat/issues/30564

akshithere commented 4 months ago

Hey @paymanzafar1 It seems like you're facing this issue for a long time now. I will go through the issues you mentioned to see if I could find any leads from the discussions there. Last time I tried, I could not replicate the issue on my development setup. It could be possible that in the newer releases this might be fixed by the team. I would urge you to follow RocketChat releases and always keep your RC server up to date. While I personally try to find any loophole that might be leading to this. If you could share more information about your setup that would help me rectify the problem. Thanks again for your patience :)

akshithere commented 4 months ago

Hey @paymanzafar1 I again tried to check if the issue you raised here could be replicated and the system messages worked exactly as expected. I'm unable to figure out why exactly you are facing the issue. My guess is there might be a possibility that the issue is your setup specific or is resolved in newer versions like 6.10 If your guess that this issue might be related to #30095 or #30564 is true then I have already raised a PR #32749 for those issues for the team to review it. Let us see if that fixes this issue. Again I would emphasize on keeping your RC version up to date.

System Messages Appearing Correctly

https://github.com/RocketChat/Rocket.Chat/assets/130065975/3d3f96d1-a5d4-4a50-b348-6b9f41c12bff

Thank you for your patience and cooperation.