search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.09k stars 10.35k forks source link

Incorrect Email Validation and Persistent display of error message on message selection in MailExportForm #32974

Open smritidoneria opened 1 month ago

smritidoneria commented 1 month ago

Description:

The validateEmail function does not correctly validate email addresses according to the RFC standard. The error message for the messagesCount field is persistently displayed whenever a message is selected.

Steps to reproduce:

  1. Go to export messages
  2. Write any invalid email.
  3. click on send

Expected behavior:

If an invalid email is entered, it should display an error. Additionally, if the message is not selected first and the send button is clicked, it should display an error. However, if the user then selects the message, the error should not be displayed.

Actual behavior:

https://github.com/user-attachments/assets/6a3ec43a-ede5-4f29-89d9-3d8ec40111c1

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

smritidoneria commented 1 month ago

If the issue is relevant, I want to work upon this

reetp commented 1 month ago

Thanks for reporting.

Server: 6.12.0

I don't think so - 6.11 hasn't been released yet?

Please confirm the version.

function does not correctly validate email addresses

It looks like you mean it does not validate addresses at all?

smritidoneria commented 1 month ago

Rocket chat version-6.10.2

yes, the validator do not seems to render the email address properly

reetp commented 1 month ago

Thanks for your work.

I have requested that this be reviewed.

Please note that this may take some time as it will have to go in the queue with lots of other work.

casalsgh commented 1 month ago

FYI - Community Liaison (reetp) shared this with internal teams and we'll be working on it soon (including review to existing proposed PR)

Starkz24 commented 1 month ago

I have solved this issue if this is not resolved till now please assign it to me.

reetp commented 1 month ago

I have solved this issue if this is not resolved till now please assign it to me.

No one assigns issue here.

You are free to work on whatever you want.

However, please see the previous team response.

This already has a PR and is is under review by the team so look at other issues - feature requests is a good place, or look at apps.