RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.04k stars 10.33k forks source link

Emoji identifiers in headline markdown are not evaluated #33067

Open func0der opened 1 month ago

func0der commented 1 month ago

Description:

Emoji identifiers in headline markdown are not interpreted

Steps to reproduce:

  1. Write a new message
    # :newspaper: This is a headline
  2. Hit 'Send'

Expected behavior:

I expect :newspaper: to show up as :newspaper:

Actual behavior:

It shows up as :newspaper: This is a headline

image

Server Setup Information:

Client Setup Information

Additional context

If works if I paste in the emoji directly and not with its identifier

Relevant logs:

reetp commented 4 weeks ago

Thanks for reporting.

As per the docs please always test on the latest version before reporting as Rocket.Chat is fast moving and things are often fixed in newer versions.

I'd also update your own version to the latest - there is a security fix in there IIRC.

https://github.com/RocketChat/Rocket.Chat/releases/tag/6.9.5

I have tested this on open.rocket.chat which is always 'latest' and I can see it occurring.

I'll mention it to the team.

yaswanthkosuru commented 2 weeks ago

The ui renders based on md field.So i need to change Rocket.Chat/packages/message-parser/src/grammar.pegjs to generate correct md field . correct me if i am wrong.