RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.44k stars 10.52k forks source link

chore: Add shebang line, -p flag to mkdir, and clean up unwanted characters in build.sh #33123

Open anoniz opened 2 months ago

anoniz commented 2 months ago

Description:

Summary: The build.sh script in the Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/ directory is missing a shebang line and fails to create directories correctly due to the absence of the -p flag with the mkdir command. Additionally, the script contains some unwanted characters that could be cleaned up.

Steps to Reproduce:

  1. Navigate to Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/.
  2. Run the build.sh script without specifying the shell explicitly.
  3. Observe the errors related to directory creation and the script's execution.

Expected Behavior:

Actual Behavior:

File Path: Rocket.Chat/apps/meteor/packages/rocketchat-livechat/plugin/build.sh

Additional Information:

reetp commented 2 months ago

Thanks for reporting this.

It would be great if you could create a PR and we can ask the devs to take a look.

anoniz commented 2 months ago

yeah sure,, i have solved the issue. making PR soon

anoniz commented 2 months ago

@reetp Hi, I have made a PR, have a look.

reetp commented 2 months ago

No need @ anyone thanks.

I read it all when I get time.

I'll refer this to the team.

anoniz commented 2 months ago

ok, thanks

reetp commented 2 months ago

This is in the queue for review but may take a while.

anoniz commented 2 months ago

ok, thanks for letting me know