OTR Starred Messaging issue

[smritidoneria]

Description:

While OTR, If the user starred the message, it is not visible in the starred message modal.

Steps to reproduce:

1. Go to the direct message interface
2. Click on the OTR.
3. Once the request has been accepted by the other user, try to starred the messages send in the OTR chat.

Expected behavior:

There can be two expected behaviours-

1. As the message sent during OTR is not stored in cache or any storage cookies, so we should not allow the user to star the message during OTR.
2. If we are allowing user to star the message in OTR, then the respective message should be visible in the Starred message modal.

Actual behavior:

Right now, Rocket chat is allowing the user to star the message during OTR but it is not visible in the Modal.

https://github.com/user-attachments/assets/4b57fd70-2712-414c-bac3-c3e9ba62b022

Server Setup Information:

• Version of Rocket.Chat Server: 6.12.1
• License Type: Enterprise
• Number of Users: 4
• Operating System: MacOS
• Deployment Method: docker
• Number of Running Instances: 1
• DB Replicaset Oplog: Enabled
• NodeJS Version: 14.21.4
• MongoDB Version: 7.0.5

Client Setup Information

• Desktop App or Browser Version: Safari 17.5
• Operating System: MacOS

Additional context

Relevant logs:

[smritidoneria]

There can be two scenario to solve this problem that I have mentioned in the expected behaviour column in the issue, Kindly let me know which one works, so that I can start working upon this issue.Thanks!

[reetp]

Always advise

Deployment type Licence version

Also why two instances?

[smritidoneria]

Always advise

Deployment type Licence version

Also why two instances?

hey @reetp ,updated the issue with the deployment and the license version, and the running instances is 1 only.

[akshayw1]

Can I work on this issue?

[reetp]

Can I work on this issue?

When the OP has already said this, you might be better off looking at other issues....

Kindly let me know which one works,

so that I can start working upon this ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Note, anyone can try anything. But as mentioned many times before, it has to go through a lot of departments before it will be considered or accepted. Rocket is not a startup and changws today are slow, and incremental.

Best places to look are feature requests, or creating apps.

[smritidoneria]

hey @reetp , can you please tell which expected behavior should we implement for starring messages during OTR chats: prevent starring since messages aren't stored, or allow starring with visibility in the Starred Messages modal?

[reetp]

Please don't @ people.

I read everything.

Currently I'm on vacation. And note I don't work for Rocket.

I will try and get a dev to comment when I get 5 minutes.

[marceloschmidt]

IMO we should prevent starring messages since they are not persistent.

[reetp]

Added to Casals watch list...

[casalsgh]

in contact with internal product team for it; asked for inputs. I agree with Marcelo on "we should prevent starring messages since they are not persistent."

[casalsgh]

Based on my conversation with Product team, OTR messages should NOT be starred. We'll be working to actually remove this "design flaw". With that, scenario 1 is the one to be followed " As the message sent during OTR is not stored in cache or any storage cookies, so we should not allow the user to star the message during OTR."

smritidoneria, if you are willing to work on a PR related to it, please do and let us know here (just drop a message, I'll get the warning). Will make sure if you submitted, it gets reviewed ASAP.

[smritidoneria]

casalsgh,I would like to work upon this issue.

[reetp]

casalsgh,I would like to work upon this issue.

Go for it!!