RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.67k stars 10.66k forks source link

Cannot Set Bio to Empty #33783

Open deathbarn opened 3 weeks ago

deathbarn commented 3 weeks ago

Description:

I would like to delete the Bio settings from my profile. When I delete all the Bio input and click save, a success notification appears. However, the Bio is not actually deleted and remains there. Is this by design, or is it a bug?

Steps to reproduce:

  1. Enter bio and save it.
  2. Delete all entries in bio and save.
  3. Check the profile.

Expected behavior:

bio should be empty.

Actual behavior:

The data from Step 1 remains in bio.

Server Setup Information:

Client Setup Information

Additional context

Relevant logs:

When saving the bio with an empty field, no output appeared in the server logs. However, the following log was displayed in the browser console.

verifyErrors.js:34 Device Management is disabled on unsecure contexts, see https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts/features_restricted_to_secure_contexts
akshat99812 commented 3 weeks ago

I would like to work on the issue

RishabhDotasara commented 1 week ago

@akshat99812 Are you still working on this ? Or Can i work on it?

Curious-Goblin commented 1 week ago

If anyone is not working on this I would like to work on the issue

casalsgh commented 6 days ago

Nice to see the PR curious-goblin; there were some changes requested. let us know when good for a new review =)

Curious-Goblin commented 6 days ago

Thank you for the feedback. I have made all the requested changes and believe everything is addressed now. Please let me know if there’s anything else to adjust. Looking forward to your review.