search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.74k stars 10.7k forks source link

OTR: raw/encrypted binary messages displayed after OTR session is finished #6526

Open localguru opened 7 years ago

localguru commented 7 years ago

Rocket.Chat Version: 0.52.0, 2.2.0

I still see the raw/encrypted messages of some users after the OTR session is finished. A restart doesn't remove the messages.

rc_otr_bug

marceloschmidt commented 7 years ago

Hi @localguru do you have steps to reproduce the problem?

marceloschmidt commented 7 years ago

Can anyone confirm this is still happening?

mddvul22 commented 7 years ago

I see this on 0.55.1

gregs007 commented 7 years ago

Still see this on 0.56.0. I think what causes it is when you are in the middle of OTR session and try to send a screenshot. Nothing happens in the OTR session, but it's the only thing I can see that's been different between OTR sessions that disappear and OTR sessions that continue to display RAW binary chats. Interestingly enough the screenshot will not show when you're in the OTR session, but it will show in the middle of the binary conversation after you restart/reload the client.

gregs007 commented 7 years ago

Also what causes this is when you press up arrow to edit a message while in an OTR session. As soon as you do, the edited message changes to binary output and after the session is over, the binary messages will continue to exist in the database.

mlanner commented 7 years ago

I have a similar problem, I think. I'm running 0.57.2.

I start the OTR, use it, close the OTR session. The messages stay visible until I restart the RC app.

PKeidel commented 6 years ago

Problem is still there in 0.60.3.

It also occours, if you are in an OTR session and edit your message. Then the JSON is shown instead of the new edited message

mddvul22 commented 6 years ago

@PKeidel I think this will be getting resolved by the new OTR implementation: https://github.com/RocketChat/Rocket.Chat/pull/7181

localguru commented 5 years ago

This is still a bug in RC 2.2.0.