RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.5k stars 10.55k forks source link

Camera can sometimes stay active after a video chat has stopped #7680

Open rcgottlieb opened 7 years ago

rcgottlieb commented 7 years ago

Description:

I started a video chat that failed as the other person never saw my request (that's a different bug though). This bug is about the fact that after I hit stop, my camera (on my Thunderbolt display) stayed active! I couldn't reproduce after I restarted Rocket.Chat so this is an intermittent bug unfortunately!

Server Setup Information:

Steps to Reproduce:

  1. Start a video chat
  2. Stop the video chat
  3. Notice that the camera is still active by the green light on either the monitor or laptop

Expected behavior:

The camera should turn off

Actual behavior:

In some cases, when a video chat fails, it does not turn off.

Relevant logs:

I don't have access to the server, so this is from the client. Also note that I'm not permitted to give out our actual server address for the chat server, so I changed it to domain.foo.com: webview.js:167 active setted https://chat.domain.foo.com webview.js:75 webview: CachedCollection rooms => webview.js:75 webview: CachedCollection subscriptions => webview.js:75 webview: WebSocket connection to 'wss://chat.domain.foo.com/sockjs/730/kg98n96u/websocket' failed: WebSocket is closed before the connection is established. webview.js:75 webview: CachedCollection public-settings => webview.js:75 webview: CachedCollection rooms => webview.js:75 webview: CachedCollection subscriptions => webview.js:75 webview: CachedCollection permissions => 4webview.js:75 webview: CachedCollection public-settings => 4webview.js:75 webview: CachedCollection permissions => webview.js:75 webview: Exception in template helper: TypeError: Cannot read property 'katex_enabled' of undefined at r (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:313:9530) at Object.katexSyntax (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:313:11255) at https://chat.domain.foo.com3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31303 at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:17158 at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31936 at Function.e._withTemplateInstanceFunc (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:140:5645) at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31843 at Object.p.call (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:206:1921) at P.DIV.w.If.P.SPAN.P.A.href (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:312:16233) at f.View. (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:27950) 5app.js:329 webview: CachedCollection rooms => 72app.js:329 webview: CachedCollection subscriptions => app.js:421 active setted https://chat.domain.foo.com 102app.js:329 webview: CachedCollection subscriptions => app.js:421 active setted https://chat.domain.foo.com 21app.js:329 webview: CachedCollection subscriptions => 9app.js:329 webview: [object Object] app.js:329 webview: Exception in template helper: TypeError: Cannot read property 'katex_enabled' of undefined at r (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:313:9530) at Object.katexSyntax (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:313:11255) at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31303 at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:17158 at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31936 at Function.e._withTemplateInstanceFunc (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:140:5645) at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31843 at Object.p.call (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:206:1921) at P.DIV.w.If.P.SPAN.P.A.href (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:312:16233) at f.View. (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:27950) 3app.js:329 webview: CachedCollection subscriptions => 3app.js:329 webview: CachedCollection rooms => 9app.js:329 webview: CachedCollection subscriptions => 7app.js:329 webview: [object Object] app.js:329 webview: Exception in template helper: TypeError: Cannot read property 'katex_enabled' of undefined at r (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:313:9530) at Object.katexSyntax (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:313:11255) at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31303 at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:17158 at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31936 at Function.e._withTemplateInstanceFunc (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:140:5645) at https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:31843 at Object.p.call (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:206:1921) at P.DIV.w.If.P.SPAN.P.A.href (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:312:16233) at f.View. (https://chat.domain.foo.com/3bb2a7c7e9c2458b6ad87f3bedebb604d8fc2a6f.js?meteor_js_resource=true:139:27950) 3app.js:329 webview: CachedCollection subscriptions => app.js:329 webview: [object Object] 3app.js:329 webview: CachedCollection subscriptions => app.js:329 webview: [object Object] 9app.js:329 webview: CachedCollection subscriptions => 3app.js:329 webview: CachedCollection rooms =>

geekgonecrazy commented 7 years ago

Was this a jitsi conversation or webrtc?

rcgottlieb commented 7 years ago

I'm not sure. I'd guess webrtc as I don't think we would have used anything beyond defaults.

geekgonecrazy commented 7 years ago

This is what I would assume. Thanks!

pmesolution commented 7 years ago

Same issue for me. Duplicate of https://github.com/RocketChat/Rocket.Chat/issues/7250 ?

HumphRey123 commented 6 years ago

same issue for me