RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.58k stars 10.59k forks source link

Cache sound/emoji assets #9313

Open geekgonecrazy opened 6 years ago

geekgonecrazy commented 6 years ago

Description:

Right now we are forcing cache-control: public, max-age=0 So every reload is resulting in these being reloaded. Not only wasteful... very slow

https://github.com/RocketChat/Rocket.Chat/search?utf8=%E2%9C%93&q=cache-control&type=

vchrombie commented 6 years ago

Can I work on this issue?

TwizzyDizzy commented 6 years ago

@vchrombie if you're still interested, maybe @geekgonecrazy can assign this to you :)

Cheers Twizzy

geekgonecrazy commented 6 years ago

We will gladly take PR's most important thing here is we need to cache. But if it's updated it needs to bust that cache