search

RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.33k stars 10.46k forks source link

Where is Audio & Video call Button ? #9632

Closed RiusmaX closed 5 years ago

RiusmaX commented 6 years ago

Description:

I've installed a fresh instance of Rocket.Chat 0.61 on Ubuntu 16.04 with snapd and when i'm in a private chat with someone, I can't see the "Call Button" for start an audio or a video call anywhere (WebRTC is set).

Server Setup Information:

Steps to Reproduce:

  1. Run a VM with Ubuntu 16.04
  2. Run in a terminal "sudo snap install rocketchat-server"
  3. Go to http://:3000
  4. Create an account
  5. Ask a Friend or take a second device to create a second account
  6. Try to launch a call

Expected behavior:

The buttons "Call" is displayed in the user section.

Actual behavior:

Impossible to find the button anywhere. I can only use the Jitsi call feature.

hortonelectric commented 5 years ago

Not having mobile support for audio and video calls in Rocket.chat is blocking my organization from adopting this in our enterprise application. Can somebody speak to the challenges or something, anybody from the dev team? We are willing to offer dev support!

Shaverdoff commented 5 years ago

Not having mobile support for audio and video calls in Rocket.chat is blocking my organization from adopting this in our enterprise application. Can somebody speak to the challenges or something, anybody from the dev team? We are willing to offer dev support!

in mobile (ios or andr-backet) webrtc/jitsi/bigbluebutton not implemented. webrtc works only in desktop or web with PG and CH style conversations but how i see only in directmode (maybe i am wrong). you must click on Member list icons and choise people. like that

default

tassoevan commented 5 years ago

@hortonelectric AFAIK, Jitsi integration is coming soon to the iOS and Android (https://github.com/RocketChat/Rocket.Chat.Android/issues/466) apps.

rasos commented 5 years ago

@hortonelectric Jitsi integration is already available in the fairchat app (which can connect to any RC server, see Android / iOS stores).

9joshua commented 5 years ago

@Shaverdoff 'Start Audio Call' doesn't work for me on RC 0.73.2. Does it work for you?

Shaverdoff commented 5 years ago

@Shaverdoff 'Start Audio Call' doesn't work for me on RC 0.73.2. Does it work for you?

only in CH & PG. even enable on direct - no option.

Shaverdoff commented 5 years ago

@hortonelectric Jitsi integration is already available in the fairchat app (which can connect to any RC server, see Android / iOS stores).

on mobile ios client no any video options like start video(jitsi/BB) or something else like WebRTC. on mobile android client webrtc option is appears but it grayout like disabled, even if options turn on on server side.

rasos commented 5 years ago

@Shaverdoff Jitsi must be configured on your server, then you see in the fairchat app in any chat or channel in the lower bar a video icon, which launches the Jitsi Meet app seamlessly (or suggests to install it first).

19-02-02 10-15-36 0019

Shaverdoff commented 5 years ago

@Shaverdoff Jitsi must be configured on your server, then you see in the fairchat app in any chat or channel in the lower bar a video icon, which launches the Jitsi Meet app seamlessly (or suggests to install it first).

19-02-02 10-15-36 0019

ofcouse it configured.. 074 tar m-p : IOS 12.1.3 client 3.2.0 (223) this photo from mobile img_5599 and this photo from desktop client. 2019-02-02 16 44 55 do not know how in currently android version was, but cuple month ago no point to video not to mention about photo...

rasos commented 5 years ago

The screenshot with the cat is from the fairchat app - it is an independent app development compatible with RocketChat servers, which has video calls integrated.

Android: https://play.google.com/store/apps/details?id=com.osalliance.rocketchatMobile

iOS: https://itunes.apple.com/at/app/fairchat/id1301616129?mt=8

Source Code: https://git.fairkom.net/chat/fairchat/

Shaverdoff commented 5 years ago

The screenshot with the cat is from the fairchat app - it is an independent app development compatible with RocketChat servers, which has video calls integrated.

Android: https://play.google.com/store/apps/details?id=com.osalliance.rocketchatMobile

iOS: https://itunes.apple.com/at/app/fairchat/id1301616129?mt=8

Source Code: https://git.fairkom.net/chat/fairchat/

after add server and click to it - app crash) cool!) i wait until ios team with Refael as Lead will procced with video

pwittke commented 5 years ago

any updates?

ministry-of-code commented 5 years ago

How can it be that a core feature is fundamentally broken and nobody cares?

Shaverdoff commented 5 years ago

now even webrtc enable on pv - video/audio button do not work))

reetp commented 5 years ago

How can it be that a core feature is fundamentally broken and nobody cares?

It's not that they don't care, but the direction of travel is to remove this sort of functionality from the core and move it to Apps/External programs eg in this case Jitsi and in say the case of the internal bot to an external bot system.

It means it simplifies the core making it easier to maintain and manage.

Also remember to date Rocket is essentially Alpha which means things get chopped and changed.

ministry-of-code commented 5 years ago

@reetp thanks for the information. we're in the process of evaluating to use rocket chat for our company and this does not really help to say "it's great, lets go with it". I understand that it makes sense to remove this stuff from core and replace with external services - but even these integrations are broken. We integrated Jitsi and it does not work. When someone starts a video conference, nobody in the channel can join because the link simply does not work (nothing happens when the link is clicked). Also, the admin menu entry WebRTC should be remove when it does not work/is not integrated any more.

9joshua commented 5 years ago

I would say it is foolish to stop maintaining a core feature unless a viable app can replace it. Otherwise, we let things deteriorate while we anticipate something that may never come to pass. And in the case of WebRTC, I think 1 to 1 calls should always be a core functionality. What's next? Do we need to find an app for messages? Should RocketChat be reduced to an app container?

This issue has persisted for more than a year now. It's time to fix it and stop waiting for apps.

HammyHavoc commented 5 years ago

@discon-nected, ridiculous, right? With this thought process in mind and a lack of basic communication functionality outside of messaging, we've been forced to go elsewhere for our communication needs. It's a pity, because Rocket.Chat was otherwise a very promising project, and I've enjoyed contributing.

9joshua commented 5 years ago

@HammyHavoc I guess the RC team became busy selling their paid platforms. I have noticed issues are left open for years now and/or closed with "This is better suited for apps" or something similar.

i.e. https://github.com/RocketChat/feature-requests/issues/610 https://github.com/RocketChat/Rocket.Chat/issues/5506 https://github.com/RocketChat/Rocket.Chat/issues/3416 https://github.com/RocketChat/feature-requests/issues/637

Alwandy commented 5 years ago

As some has mentioned, we're also currently evaluating to use rocket.chat but what hinders us is this functionality! We also do not want to use external apps / third party services to enable this feature, we really would like to use it if it's part of the core as we're self-hosting again for confidential reasons.

pwittke commented 5 years ago

Cutting a core feature that made many peoply move to RocketChat would be a mistake.

For many companies the sole reason of using such a system is to have it on a standalone basis with no external services connected due to privacy/security/confidentiality reasons.

And if the feature is planned to be removed I agree there should not be an option for it and the website should be updated.

But I guess we have to wait for the Devs to answer and clarify at one point in time.

image

image

ggazzo commented 5 years ago

@discon-nected we really want to move to apps... but it doesn't mean we gonna to abandon the features, it's how the framework/code structure works, our apps are our responsibility as the core code is. But on the other hand, if you don like some app/feature you could remove/install/develop a different app.

I have noticed issues are left open for years now and/or closed with "This is better suited for apps". again its not true, your team its not so huge as you think. ok, its true we have tried to make some money, but our development team is 100% on nonpaid features. (some examples, federantion, threads and the new livechat). I guess the RC team became busy selling their paid platforms.

@pwittke no! we never had this in mind, we have a planned project to fix/improve videos/audio, and I/we want to start very soon.

And if the feature is planned to be removed I agree there should not be an option for it and the website should be updated.

9joshua commented 5 years ago

we really want to move to apps... but it doesn't mean we gonna to abandon the features

Then why can't we make audio calls (for over a year now)?

And don't get me wrong, I have no problem using RC developed apps, but using 3rd party apps to achieve what should be core functionality while at the same time compromising security is a problem. (i.e., Jistsi)

Also, closing an issue with "this is better suited as an app" means that RC does not want to develop the particular feature in-house.

MathiasGmeiner commented 5 years ago

https://github.com/RocketChat/Rocket.Chat/issues/9632#issuecomment-471613510 @ggazzo thanks for the clarification!

ggazzo commented 5 years ago

we really want to move to apps... but it doesn't mean we gonna to abandon the features

Then why can't we make audio calls (for over a year now)?

And don't get me wrong, I have no problem using RC developed apps, but using 3rd party apps to achieve what should be core functionality while at the same time compromising security is a problem. (i.e., Jistsi)

there are no excuses fot that, actually, I just can say we had no time to make a proper fix... but believe me, I'm not happy with that, please await for the next weeks :x

9joshua commented 5 years ago

That's great news. I will wait impatiently :D

rasos commented 5 years ago

@Shaverdoff you may try again the fairchat app, the 1.2.1 version has got fixed the server change bug. It seamlessly calls the Jitsi Meet app when you get an invitation to join a conference call.

Shaverdoff commented 5 years ago

@Shaverdoff you may try again the fairchat app, the 1.2.1 version has got fixed the server change bug. It seamlessly calls the Jitsi Meet app when you get an invitation to join a conference call.

in 12/1/4 iOS that fairchat forclose after try to enter server url and press connect. so...

ggazzo commented 5 years ago

@discon-nected please check RocketChat/Rocket.Chat#13675

9joshua commented 5 years ago

Sweet. Thank you!

melroy89 commented 4 years ago

Indeed, I found it too:

screenshot

Man that's in a really unintuitive spot.

But that is only for a audio call one-on-one?

What about a Jitsi audio call only in either a channel or private group?