Bad Words filter seems to be catching 'Hello'

[RichardFoxworthy]

Description:

The bad words filter seems to now be triggering on partial matches - eg it will now filter out the word 'hello', presumably because it includes the word 'hell'. Which I don't consider to be a bad word any way, but whatevs ....

Server Setup Information:

• Version of Rocket.Chat Server: v0.62.0-develop
• Operating System: Linux
• Deployment Method(snap/docker/tar/etc): Heroku one click
• Number of Running Instances: 1
• DB Replicaset Oplog: Disabled
• Node Version: v8.9.4
• mongoDB Version:

Steps to Reproduce:

1. Set 'Allow Message bad words filtering' to 'True' under Admin --> Settings --> Message
2. Go to any channel and send a message that includes the word 'hello'

Expected behavior:

1. I expect the word 'hello' to be rendered without modification
2. If a word really is to be filtered I expect to see the same number of * as there are letters in that word - ie if hello really were to be filtered, I would expect to see '****' rather than ''

Actual behavior:

Message will be rendered with a single '*' in place of the word 'hello'

Relevant logs:

NA

[nemani]

For me the word hello is rendered as *****

[nemani]

I looked into this issue, seems like its a problem with the package we are using. https://github.com/web-mech/badwords/issues/25

[nemani]

We can either A: Switch to a different package, B: fix this issue in the upstream or C: Write our own filter.

[nemani]

I looked into the library, and to filter words like shitshit, it looks for bad words anywhere in the given word. This causes a lot more problems as words like document and title also get filtered. I think its better to have exact matching of bad words.

[didierhk]

mongodb and cluster are also being filtered

[knrt10]

@RichardFoxworthy I think this issue is fixed in 1.0.0-develop. Try checking it. Cheers 👍