RocketChat / feature-requests

This repository is used to track Rocket.Chat feature requests and discussions. Click here to open a new feature request.
21 stars 9 forks source link

Plain text emails for better formatted direct reply by email feature. #134

Open stevenmcastano opened 5 years ago

stevenmcastano commented 5 years ago

I'm going to cross post this here and under issues as I'm not totally sure if this is a feature request or a bug.

I'm trying to get the reply by email functionality working... and it is, but with rendering problems. If I send a message to a user that's offline it does send them an email with the message contents and I have not modified the templates at all. This is the default everything.

The server OS is Ubuntu 18.04.2 with RocketChat 1.1.5 and the emails are being sent through postfix into a Microsoft Exchange server to our users running outlook.

The sent email from RocketChat goes out fine, but no matter how the user replies, HTML or plain text, the incoming message put back into chat is a huge mess. This happens regardless of HTML or plain text replies. See the screen shots below ---

This is the screenshot of the original message and what the reply looks like when it comes in from an HTML reply:

Screen Shot 2019-06-20 at 1 23 04 PM

This is the screenshot of the reply exactly as it is coming out of outlook:

Screen Shot 2019-06-20 at 1 19 13 PM

The here is what it looks like when replied to via outlook after telling outlook to reply with plain text follow by what outlook looks like when sending that reply:

Screen Shot 2019-06-20 at 1 24 47 PM

The outlook plain text email reply:

Screen Shot 2019-06-20 at 1 24 11 PM

I guess the feature request here is to potentially have a full plain text email sent and received so that only the actual reply appears in RocketChat without the rest of the email stuck in there.

I'm doing to do my best to test with another email client ASAP... just to see if it works somewhere else... but out entire organization users Outlook so making that work is really the only way for me to go.

Thanks!

*SMC

reetp commented 5 years ago

Please don't cross post. It is unneccessary and just confuses.

This follows conversations on open.rocket

Essentially when Outlook replies to a message the formatting is not rendered clearly in Rocket (please post a shot of this)

The request is really to have an option to send messages in plain text rather than html / mixed multipart.

Things to test. Is this due to poor Outlook formatting?

What happens on other clients?

Can anything be done in Rocket about parsing what may be increasingly complicated responses? Think differing indents, top/bottom posting etc....

Ultimately Rocket is a chat client, not an email client.

stevenmcastano commented 5 years ago

This appears to be a problem with text encoding and boundary recognition... I can post the entire email source if need, but there is the important part. The headers of the email tell us that inside of the boundary of --B_3643889992_1119462819 is out email. If you extract that section of the multipart email you get:

Content-type: text/plain;
    charset="UTF-8"
Content-transfer-encoding: quoted-printable

Reply to see original source.

=20

*SMC

=20

From: Steven Castano <rocketchat@xxxxxxxxxx.com>
Reply-To: <rocketchat+FDtm8KuZSRobK7Lhy@xxxxxxxxxx.com>
Date: Thursday, June 20, 2019 at 1:23 PM
To: <rocketchat-admin@xxxxxxxxxx.com>
Subject: [BenefitAlign Rocket.Chat] You have been direct messaged by Steven=
 Castano

=20

BenefitAlign Rocket.Chat
Steven Castano sent you a message:

A second direct messages to the same offline user.GO TO MESSAGEYou can dire=
ctly reply to this email. Do not modify previous emails in the thread.
Blog | Github | Facebook | Instagram
=C2=A9 Rocket.Chat Technologies Corp.
Made with =E2=9D=A4=EF=B8=8F in =F0=9F=87=A7=F0=9F=87=B7 =F0=9F=87=A8=F0=9F=87=A6 =F0=9F=87=A9=F0=9F=87=AA =F0=9F=87=AE=F0=9F=87=B3 =F0=9F=87=AC=F0=9F=87=A7 =F0=9F=87=BA=F0=9F=87=B8=20
=20

Then all you have to do is decode the "UTF-8 quoted-printable" text to plain text... which can be done online here: https://www.webatic.com/quoted-printable-convertor

If you paste the contents above into the "Encoded" section it decodes perfectly clearly to:

Content-type: text/plain;
    charset="UTF-8"
Content-transfer-encoding: quoted-printable

Reply to see original source.

*SMC

From: Steven Castano <rocketchat@xxxxxxxxxx.com>
Reply-To: <rocketchat+FDtm8KuZSRobK7Lhy@xxxxxxxxxx.com>
Date: Thursday, June 20, 2019 at 1:23 PM
To: <rocketchat-admin@xxxxxxxxxx.com>
Subject: [BenefitAlign Rocket.Chat] You have been direct messaged by Steven Castano

BenefitAlign Rocket.Chat
Steven Castano sent you a message:

A second direct messages to the same offline user.GO TO MESSAGEYou can directly reply to this email. Do not modify previous emails in the thread.
Blog | Github | Facebook | Instagram
© Rocket.Chat Technologies Corp.
Made with ❤️ in 🇧🇷 🇨🇦 🇩🇪 🇮🇳 🇬🇧 🇺🇸 

It should be easy in code at the point to read until you get to the "From:" line with some sort of regex like "^From: .rocketchat@.>$" filling in whatever people configure as their sending address... then only grab what's left over which should be just the text intended to come through as a message.

gelinger777 commented 4 years ago

We have similar issue

image