RocketChat / feature-requests

This repository is used to track Rocket.Chat feature requests and discussions. Click here to open a new feature request.
21 stars 9 forks source link

[Improvement] Pinned messages shouldn't disappear from chat and should be accessible all the time #365

Open ankar84 opened 4 years ago

ankar84 commented 4 years ago

Description:

IMHO, Pin message functionality in Rocket Chat do not work as it should be work. Pin message do not actually really pin any message. It's mark a message with pin icon and some kind of quoting that message. image And when users continue to talk in that chat, soon that pinned message will be gone in history, and only way to get that message will be open hamburger (3 dots menu) and select Pinned Messages. But what's the big difference between pinned and starred messages in that case? Icon? Pinned message should be really pinned to chat's header (like chats leader), it should freeze (stuck, what ever) below chats topic, description and announcement and be accessible all the time - it is a proper pin message functionality looks like.

Steps to reproduce:

  1. Pin a message
  2. Write a lots of messages or couple large messages
  3. Pinned message is gone - scrolled in message history

Expected behavior:

Pinned message should be really pinned to chat's header (like chats leader), it should freeze (stuck, what ever) below chats topic, description and announcement and be accessible all the time. Look like Telegrams pinned messages work - that is a proper realization (both web and mobile) image image

Actual behavior:

Pinned a message and write some messages and big message image

Pinned message not available (scrolled out from screen) image

So, if pinned message unavailable why it's called pinned? Pinned to what? To itself?

Screens are from open.rocket.chat which on version 3.5.0

Server Setup Information:

Client Setup Information

ankar84 commented 4 years ago

@ggazzo can you take a look at that issue and tell what you think about it? Thanks!

nixxou commented 4 years ago

Right now, it's more like 'featured' than pinned. That says, the actual behavior can be usefull in some case, like mark important stuff to not purge when using the prune room.

ankar84 commented 4 years ago

Right now, it's more like 'featured' than pinned. That says, the actual behavior can be usefull in some case, like mark important stuff to not purge when using the prune room.

Totally agreed! But star message already exists for that purpose. @sampaiodiego @rodrigok what do you think about that?

sampaiodiego commented 4 years ago

oh I see, the feature might lead to an unexpected result, as there will not be anything actually pinned somewhere..

we might need both? idk

ankar84 commented 4 years ago

we might need both? idk

I think, that mark important messages user now can use star/unstar function. But now pin and star play almost same role in exception that pinned messages could be excluded from purge policy.

ankar84 commented 3 years ago

@sampaiodiego hey, Diego! Any news about that pinned messages feature?

sampaiodiego commented 3 years ago

not yet.. let me ping @milton-rucks .. what do you think about this one @milton-rucks ? is something we'd add to the product at some point?