Notifications - Implementing custom group notifications

Johann-Snapp commented 8 years ago

As said in RocketChat/Rocket.Chat#1315, @geekgonecrazy doesn't like when people notify @all, and he's not the only one. Plus, it's comfortable when you can call @frontends, @backends, @lawyers, ect.

This issue is not about asking a feature, it's more about how to implement it correctly. So, let's go !

In order to configure it, we'll need to persist custom mentions.
As admins could configure it, what happens in case of conflict between a username & a mention-group name ?
We'll need to update the mentions autocomplete popup
What happens when we click on the mentionned group ? Does it open the right panel with user list ? How does it work for @all ? Does it shows the channel's user list or does it send data to the panel ?
In which admin section do we put it ? Users ? Channels ? Message ? New section ?
Maybe we can implement the confirmation popup when notifying many people: RocketChat/Rocket.Chat#909
Maybe we could add aliases to mentions so that we search by name or alias.

Did I forget something ? Is there someone motivated to help me working on it ? Is there someone already working on it ?

damienmollard commented 8 years ago

+1

Johann-Snapp commented 8 years ago

Found this: https://github.com/RocketChat/Rocket.Chat/pull/1564

engelgabriel commented 8 years ago

This will need to tied up with the ROLES, so you could mention @rolename

Johann-Snapp commented 8 years ago

If we do this, we have to setup a exclude list in order to not have things like @bot

engelgabriel commented 8 years ago

@channel will send a notification to all team members in the channel where you post the message.

@everyone notifies every member of your team. This command can only be used in the team-wide channel (usually called #general).

Both notifications will be sent to all team members in the channel whether they are active, away or offline.

@here is best for sending announcements relevant only to team members that are currently working or available.

marceloschmidt commented 8 years ago

I'll add a reference to RocketChat/Rocket.Chat#2135 as this is an important guide if we are going on that direction.

nemolivier commented 8 years ago

On this I would like :

@chans : notify all chans (only for admin, when reboot, update, etc.)
@admins / @modos : add an attention sign in front of the chan to notify a problem in chan (someone trolling, need for moderation, etc.)

engelgabriel commented 7 years ago

See for mor discussion on this feature https://github.com/RocketChat/Rocket.Chat/issues/1315 https://github.com/RocketChat/Rocket.Chat/issues/2135

CodeWarriorr commented 7 years ago

+1 It would be awesome if I could call role/group member !

As admins could configure it, what happens in case of conflict between a username & a mention-group name ?

Mentions to groups or roles could be prefixed by special char e.g. @@testers

jgtoriginal commented 7 years ago

@engelgabriel Actually I'd go for dynamic tags, for as many roles an admin creates on his instance. It would be something like, getting a list of available roles on a room, and create the specific tags for that room. Not sure how the tag command works though.

slyk commented 7 years ago

+1 need this feature.

I think admin need to create mention groups. And If he sees conflict with username, he will deal with this manually by changing user name. With good naming rules sole user wouldn't name himself using plural name ('-s' end), so conflicts will be rare.

NOT roles. Roles seems to be easy way to group people. But roles here is like system way of managing permissions. Group of users could have different chat permissions and still I want to mention them all. Connecting roles and mention groups will add unneeded restrictions.

"Users" menu is good place to configure mention groups. From there you see usernames and system can show you conflicts. It could be just sidebar button that opens sidebar with groups list. Don't think someone will have too much groups to create separate page for them.

P.S. the easy way for small teams create sort of inline alias, that will replace group name to list of usernames. Example: you wrote "@managers" and in chat it appeared as "@manager1 @manager2 @manager3"

ginnj-gilmore commented 6 years ago

+1 above solutions seem viable and it would be a great feature to have!

mxmo0rhuhn commented 6 years ago

We would love this feature!

jgtoriginal commented 6 years ago

After giving it a thought, it would be actually great to give users the option to tag themselves as 'developers', 'lawyers', etc. And also give admins the right to tag people from the dashboard. This would be only an extra attribute on the user object. From which then we can write a hook to pick tags part of the mentions functionality. How does that sound to you all?

mxmo0rhuhn commented 6 years ago

Tagging sounds like a good idea - as always LDAP integration would be awesome. For our organisation it would be better if the mentions would not be expanded. Imagine a team with 20 people or so would be expanded like: @devs could you have a look? @dev1 @dev2 @dev3 ... @dev20 could you have a look?

KrystalMoore16 commented 6 years ago

+1 please implement this feature!

On Jan 9, 2018, at 5:51 PM, mxmo0rhuhn notifications@github.com wrote:

Tagging sounds like a good idea - as always LDAP integration would be awesome. For our organisation it would be better if the mentions would not be expanded. Imagine a team with 20 people or so would be expanded like: @devs could you have a look? @dev1 @dev2 @dev3 ... @dev20 could you have a look?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jgtoriginal commented 6 years ago

after having a look at the code behind this, I think it would be highly advantageous to give owners and admins the option to turn off the @all feature on a channel basis. So say you go to #support and want to call everybody's attention, but your question is not as important to every single user there, admins would have the possibility to disallow @all and only allow @here or @some-random-team

KrystalMoore16 commented 6 years ago

Any update? Thanks!

vynmera commented 6 years ago

Perhaps we could use a different character, for example +admin? They can be role-based, but you can turn mentionability on and off per role. We can add an extra field to the role settings to how they should be displayed in chat, so that the "Admin" role will be displayed as +Admins.

BanHammor commented 6 years ago

I would really like this feature implemented, +1

bwesemann-cxp commented 6 years ago

+1 would love this feature. @all is getting annoying in large chats

Wirone commented 5 years ago

In our organization we have channels per team (public, so everybody can ask each team about something), sometimes per project (members are team that maintain project + invited people from business etc.). Most of the time there is some part of members that is responsible for the channel (let's call it "owners") and rest of members are guests. This feature would give us ability to call such "owners" without need to notify all channel members.

For example, there is channel for Jira/Confluence admins. Everybody can ask there something, but using @all or @here would notify too many people as we want to only draw Jira team's attention. Currently we can't easily mention group of users and mentioning each one is too cumbersome.

FaizanZahid commented 5 years ago

i would love to have this feature +1

williamhilliard commented 5 years ago

+1

dta5003 commented 5 years ago

Pretty please +1

This is a feature we're missing in the transition from Slack.

slyk commented 5 years ago

Maybe someone will add some more coins to bounty? And then comunity and devs will understand how this important?)

Waiting it for a long time.

gpoudrel commented 5 years ago

Great feature it would be.

Atomicbeast101 commented 5 years ago

Is this feature in consideration of being implemented at some point in the future?

slyk commented 5 years ago

Wow, so good bounty. I wish I know that programming language to write this feature by myself :)

philtweir commented 5 years ago

Now over $400, at least if completed in next couple months :)

maciek134 commented 5 years ago

Is someone working on this? I'll gladly implement this feature as I need it myself.

philtweir commented 5 years ago

As well as here, think you can check BountySource - IIRC, it has a feature to say you're working on it, to save others starting in parallel

maciek134 commented 5 years ago

Ok, bountysource wants a link to code so I'll do that when I have something substantial to show, for now I'll just let you know here that I'm working on it :)

feltra commented 5 years ago

This feature has been forgotten ?

maciek134 commented 5 years ago

Not by me, it's just going slowly as I don't have much free time atm.

Kailash0311 commented 5 years ago

Can I also work on it? @maciek134 , I am interested in implementing the feature.

slyk commented 5 years ago

wow wow, we have two minds and 4 hands on this task? this is great! this is long awaited feature, hope you can somehow cooperate with each other, to not make same work twice. Maybe split by UI and server logic?

raatti commented 5 years ago

+2 for this, desperately needed for any good group chat to create groups and aliases to mention.

philtweir commented 5 years ago

(just to highlight, at least some of that bounty is time-limited - not immediately expiring, but keen to flag)

maciek134 commented 5 years ago

Ok, so I guess @Kailash0311 decided to post a WIP PR that adds pretty much nothing to "reserve a spot"? I'm out then, I'm not going to rush anything because of a bounty... (keep in mind that this is not a trivial feature, 90% of the work is figuring out how to do it properly).

Kailash0311 commented 5 years ago

@maciek134 I just gave it a shot by implementing a part of this feature (there is still a lot to be done and lots of refactoring has to be done) and I am not after bounty, I did it as I think this feature is really needed :slightly_smiling_face:
Feel free to work on your own :slightly_smiling_face: .

slyk commented 5 years ago

Hello. We have in mid-term milestone:

Group to invite RocketChat/feature-requests#609
Mention multiple users RocketChat/feature-requests#611
And current about "notifications" RocketChat/feature-requests#634

They almost duplicates and solving one will solve others. I'm not good expert on GitHub, but maybe all of those requests need to be closed as duplicate of current one, to redirect all requests to one discussion and have ability to make one good solution for all?

@maciek134 any news from you? Kailash told that it's not about bounty for him. Maybe you can found some time for this feature?

P.S. added a little more bounty :)

maciek134 commented 5 years ago

I'll take another stab at it :)

SeaLife commented 5 years ago

Hopefully this can be used per-channel instead of per-instance.

In a large organization with like 8000 (or nearly 20k, like in RocketChat/Rocket.Chat#1315) people using rocket.chat, global groups/roles to be mention will be useless. But havin a channel (like Discord has 'servers') where you can mention the @developers or @templating would help alot.

So there must be a per-channel custom notification system?

maciek134 commented 5 years ago

I've got some free time on my hands so I'll try to have something before the end of the week.

@SeaLife yeah, that's what I was thinking - but global groups too, so you can be in a QA group but if someone mentions @qa in a channel you will only get notified if you already belong to it.

SeaLife commented 5 years ago

Did you end up with something? @maciek134 :)

maciek134 commented 5 years ago

A lot of bad feelings for meteor ;p Seriously though, I've made some progress - figured out the notification part, now I need to finish settings and I'll have something to show.

On Mon, Jul 1, 2019, 2:04 PM Mirco T. notifications@github.com wrote:

Did you end up with something? @maciek134 https://github.com/maciek134 :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RocketChat/feature-requests/issues/634?email_source=notifications&email_token=AAIX3RLQLOHCJINSCRX4XJTP5HXFTA5CNFSM4B3AFCM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY547XQ#issuecomment-507236318, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIX3RMHIJ4G5KNGSCDMHT3P5HXFTANCNFSM4B3AFCMQ .

yuritoledo commented 5 years ago

+1

Crayder commented 4 years ago

This would also be really awesome with an addition of the option to only notify people marked active.

Even further, you could add online-detection and these custom tags to the bot's api.

This would help for customer notification systems for business-class users like the company I work for a lot!

J0kerFace commented 4 years ago

This is our mostly missing function at the moment.

RocketChat / feature-requests

Notifications - Implementing custom group notifications #634