search

RocketChat / feature-requests

This repository is used to track Rocket.Chat feature requests and discussions. Click here to open a new feature request.
21 stars 9 forks source link

Add Sender header in e-mail notifications #666

Open micleclickme opened 5 years ago

micleclickme commented 5 years ago

Is your feature request related to a problem? Please describe. When we receive email notification we see "From" as "User_Name rocket_instance@email". That's look good. But a lot of e-mail clients can show additional information about email contact: exchange/zimbra will look in global address book for additional information. But rocket_instance@email is just service account, with no personality.

Describe the solution you'd like It'll be great to add one more header e-mail header "Sender" and fill it with "User_Name real_user@email". So most most e-mail clients will show that email is From: "User_Name real_user@email" on behalf of "Rocket.Chat rocket_instance@email" And if i ask email client about additional information about Sender i'll get response of saved person contact for real_user@email In addition Reply-To header still should be filled like https://github.com/RocketChat/Rocket.Chat/pull/7342 if direct reply function is active.

localguru commented 5 years ago

The bigger problem is, that most people think, they can reply on those notifications and the reply will be send to the users personal email and not the the global RC email address. This is quite confusing and a security problem.

micleclickme commented 5 years ago

I think https://github.com/RocketChat/Rocket.Chat/pull/7342 is great for resolve this problem. If you configure Rocket direct reply, reply will be sent to Reply-To address (which now is set as masked rocket instance email). If you don't configure direct email reply email will be sent to common rocket instance email provided in From header.

I think providing user email is a little bit privacy problem, but we can add user setting if he would like to his real email in sender header. Currently we can find all users email in User Information tab.

digitalhitler commented 5 years ago

I am sorry for my inappropriate boredom but all you need is a Reply-To: someone@somewhere header - all mail clients will use the address from Reply-To as recipient address (and just cuts real sender address in From header) when user is composing reply.

localguru commented 5 years ago

@micleclickme

I think RocketChat/Rocket.Chat#7342 is great for resolve this problem.

Under certain conditions "direct reply" cannot be used., see https://github.com/RocketChat/feature-requests/issues/659

localguru commented 5 years ago

I am sorry for my inappropriate boredom but ...

@digitalhitler I don't apologize for my aroused interest in your username. Could you please explain it.

digitalhitler commented 5 years ago

@localguru it`s something about my too emotional reaction and love to faultfinding in digital products, nothing related to nazis or something similar.

localguru commented 5 years ago

@digitalhitler How can a username that contains the word "Hitler" have no Nazi reference, especially if it is combined with "digital" and both words together are probably not your first and last name? I find this more than tasteless, immature and frankly completely unacceptable.

digitalhitler commented 5 years ago

@localguru Okay, thanks for your opinion that I am completely dont care.