search

RocketChat / feature-requests

This repository is used to track Rocket.Chat feature requests and discussions. Click here to open a new feature request.
21 stars 9 forks source link

Associate OAuth accounts with current logged in account when clicking in "Login with ..." #775

Open shtefcs opened 8 years ago

shtefcs commented 8 years ago

Your Rocket.Chat version: 0.28.0

I just got feedback from the user who registered via email.

When he wanted to change/update avatar, he used Login with Twitter option.

What happened is that he actually registered new account, instead just to connect.

geekgonecrazy commented 8 years ago

I know this likely wont fix the issue. But can you confirm with the latest release: 0.30.0 ?

shtefcs commented 8 years ago

I will let you know when i update.

Peace

marceloschmidt commented 8 years ago

Don't bother trying in another version :( this is a known problem and won't solve. What's happening is that when you are logged in, clicking on "Login with ..." will create another account, and then associate that account with yours if the emails match. This is not a problem exclusive to Twitter (because Twitter doesn't give out your email) but also with any service in which you use a different email. We must fix this, by associating any accounts you click on (regardless whether you have the same email or not) with your current logged in account.

shtefcs commented 8 years ago

I see. Well even Twitter doesn't provide email, we will still need to get user email on the next step.

geekgonecrazy commented 8 years ago

Related case of email mis-match: RocketChat/Rocket.Chat#3445

ghost commented 8 years ago

This happened to me just now after setting up an app account with twitter for my rocket chat installation. I recreated it anew just now and have repro steps.

  1. User goes to change avatar, clicks "login with twitter" button.
  2. Window pops up, twitter asking if it okay to authorize. User clicks affirmative "authorize app", window closes after twitter says they are redirecting.
  3. Rocket chat app redirects to registration page asking for a username to register (note the url; still /changeavatar). I have to delete all cookies set by my rocket chat install via Chrome settings to be able to log back in. Once I do delete the cookies: the login screen pops up, I login and I am back where I started (the /changeavatar ui screen).

My email address registered with twitter be the same as the one I used for my rocket chat installation.

Also, I am at version 0.33.0

geekgonecrazy commented 8 years ago

@purldator problem with twitter, is they don't pass your email address. So it doesn't matter if it matches or not, Rocket.Chat wouldn't get it. So it will always not match :smile:

But yes this is an annoying problem, that we'd like to get fixed.

shtefcs commented 8 years ago

I have around ~400 users registered with Twitter.

Noticed long time ago that mostly they are useless, cause i can't get in touch with that people anymore.

As i mention few times before, we need to get user email after Twitter authorization, as a last step in registration, cause that is most important piece of information.

Hudell commented 6 years ago

Issue RocketChat/Rocket.Chat#8496 had a small discussion about this problem as well.

Hudell commented 6 years ago

Issue RocketChat/Rocket.Chat#6483 is also related.