search

RocketChat / feature-requests

This repository is used to track Rocket.Chat feature requests and discussions. Click here to open a new feature request.
21 stars 9 forks source link

BUG/QUESTION: Unpin behavior #797

Open bkraul opened 5 years ago

bkraul commented 5 years ago

Description:

I accidentally pinned one of my messages during a conversation. This caused the message to be posted with a quote style. When I tried to unpin, nothing happened. I was expecting the "pinned" message to disappear.

Steps to reproduce:

  1. Download latest docker develop build (4ba3513).
  2. Type a message.
  3. Pin it. Will see the message being pinned.
  4. Attempt to unpin the message. Nothing happens. Pinned message remains.

Expected behavior:

I would expect the pinned/quoted message to be removed when clicking Unpin on the original message, as the pinned message itself has no option to remove.

Actual behavior:

Pinned message remains. See GIF.

unpin

Rocket.Chat

Version 1.1.0-develop
Apps Engine Version 1.4.2
Database Migration 144
Database Migration Date Fri May 10 2019 06:18:56 GMT-0500 (Central Daylight Time)
Installed at Fri Jan 25 2019 17:44:08 GMT-0600 (Central Standard Time)
Uptime 1 minutes, 25 seconds
Deployment ID dwPkHnPwaKuHALm6b
PID 1
Running Instances 1
OpLog Enabled

Commit

Hash 4ba35136153033a021b75fb3c51d40976f8674c5
Date Thu May 9 18:08:17 2019 -0300
Branch develop
Tag 1.0.1
Author Guilherme Gazzo
Subject fix (#14443)
MarcosSpessatto commented 5 years ago

@bkraul actually this is the expected behavior, when you pin a message, an announcement is inserted in the channel (like you show on your GIF). When you unpin the message, the message is removed from the list of pinned messages, but the announcement keeps in the channel (like an history of actions). See https://github.com/RocketChat/Rocket.Chat/issues/7124#issuecomment-315409710

bkraul commented 5 years ago

Not sure I follow. If I unpin the message, the announcement should be deleted, because as I mentioned, an "Unpin" action seems to do absolutely nothing. Take for instance what happened to me. I was trying to edit the message. But I accidentally pinned it. I quickly unpinned it, but the announcement stayed behind, causing confusion with the people I was communicating with. This is more apparent on DM channels.

bkraul commented 5 years ago

At least adding a delete option for the actual announcement would go a long way. The problem is that it cannot be deleted by any means (not even by an administrator, unless a full pruning operation is done).

ChristineBoersen commented 5 years ago

I had to disable it currently since it was confusing too many of my users. Being able to delete the left behind pinning would really help.

LeeThompson commented 5 years ago

This happens to me too, pin/unpin seems largely useless.

The announcement that a message was pinned or unpinned should be optional since it's largely useless too and just adds a lot of clutter.

matacino commented 4 years ago

Yes, it is also for useless and irritating for our users, that an accidentally "pinned" message does not disappear whe unpinned

audouts commented 2 years ago

I have an annoying "pinned" announcement that is left over from a deleted message. Is there a way to delete it, too?

I understand that pin/unpin announcements are part of channel history but they should not persist for deleted messages.

I also agree that it would be better to make them optional.

LeoColman commented 1 year ago

@hugocostadev Any ideas on where to start working on this issue? I'd like to contribute, but as this is many years old now, I'm not sure if it's even desirable.

The announcements are definitely still there.

LeoColman commented 1 year ago

image

There is also no option to disable that kind of system message