RocketChat / fuselage

React port of Rocket.Chat's design system, Fuselage
https://rocketchat.github.io/fuselage/
MIT License
114 stars 160 forks source link

fix: banner breaking ui when the title is not a string #1468

Closed MartinSchoeler closed 1 month ago

MartinSchoeler commented 1 month ago

SUP-634

Proposed changes (including videos or screenshots)

This fixes the UI crashing when the title passed to the banner component is an empty object or non string type This is just patching the issue, we will have to check how we are validating prop data on the ui kit

Fixes banner component crashing the ui when the title is not a string

Issue(s)

SUP-634 closes https://github.com/RocketChat/Rocket.Chat/issues/33263

Further comments

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 6facefa96c3e58cbc681cac9cf8e0229450a1dc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @rocket.chat/fuselage | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MartinSchoeler commented 1 month ago

Moving this to https://github.com/RocketChat/Rocket.Chat/pull/33689