search

RocketChat / helm-charts

Repository for RocketChat helm charts
37 stars 67 forks source link

Update helm chart to actually build and add ingress v1 support #24

Closed andrewstuart closed 2 years ago

andrewstuart commented 3 years ago

This PR adds support for kubernetes v1.22 due to the removal of v1beta1 ingress, and a values file that includes the previously missing fields.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

holubovskyi commented 2 years ago

@andrewstuart I suggest adding the ability to set ingressClassName for ingress resource. Something like that:

spec:
  {{- with $ingress.ingressClassName }}
  ingressClassName: {{ . | quote }}
  {{- end }}

It might also be good to change pathType: Prefix to pathType: ImplementationSpecific.

debdutdeb commented 2 years ago

Hey @andrewstuart thanks for your contribution! Could you rebase on the current master please?

andrewstuart commented 2 years ago

@debdutdeb should be good to go! Thanks. :smile:

pixlcrashr commented 2 years ago

@debdutdeb When will this be merged?

vmaillot commented 2 years ago

@debdutdeb we just upgrade to AKS 1.22.4 and I would need that PR merged for a customer! Any ETA on that?

Thanks a lot o/

vmaillot commented 2 years ago

@prppedro are you thinking about picking this commit for the 3.3.0 chart version as well?